ports/169252: [patch] textproc/gmetadom cannot disable building against ocaml if not present; causes future installs to fail

[Edward Sanford Sutton III]

>Number:         169252
>Category:       ports
>Synopsis:       [patch] textproc/gmetadom cannot disable building against ocaml if not present; causes future installs to fail
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 20 03:50:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Edward Sanford Sutton III
>Release:        freebsd 8.2-stable amd64
>Organization:
>Environment:
FreeBSD darkstar.l.net 8.2-STABLE FreeBSD 8.2-STABLE #0: Sun Dec 18 22:15:25 MST 2011     root at darkstar.l.net:/usr/obj/usr/src/sys/MYKERNEL8  amd64
>Description:
gmetadom runs a configure script to detect ocaml, which was not altered by the config option OCAML=off. If ocaml content is present, gmetadom still built against it which made the pkg-plist incorrect. An uninstall leaves debris and a reinstall fails as follows: 

        install  -o root -g wheel -m 444 dllmlgdome.so /usr/local/lib/ocaml/stublibs;   \
fi
ocamlfind: Conflict with another package: Library dllmlgdome.so is already installed
gmake[4]: *** [install-data-local] Error 2

>How-To-Repeat:
I assume installing the ocaml dependencies and then building the port without the OCAML option enabled will cause it to fail; I had this problem before trying to test how to get it to go away and it is on a machine with many ports installed.
>Fix:
I had to execute a manual command of rm -r /usr/local/lib/ocaml/gdome2.saved/ /usr/local/lib/ocaml/stublibs/dllmlgdome.so on the system before being able to get `make install` to succeed; should that be noted in UPDATING or should the port be updated to do that as cleanup for debris from older copies of the port? Once debris is cleaned out, the following patch will clean it up.

Patch attached with submission follows:

--- Makefile.orig	2012-06-19 14:29:36.846768378 -0700
+++ Makefile	2012-06-19 18:55:34.150253635 -0700
@@ -37,6 +37,7 @@
 		ocamlc:${PORTSDIR}/lang/ocaml
 PLIST_SUB+=	WITH_OCAML=""
 .else
+CONFIGURE_ARGS+=	HAVE_OCAMLDEP=no
 PLIST_SUB+=	WITH_OCAML="@comment "
 .endif
 


>Release-Note:
>Audit-Trail:
>Unformatted: