ports/169844: multimedia/libdvdread 4.2.0 ignores WITH_DEBUG

[Fabian Keil]

>Number:         169844
>Category:       ports
>Synopsis:       multimedia/libdvdread 4.2.0 ignores WITH_DEBUG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 14 08:10:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Fabian Keil
>Release:        HEAD
>Organization:
>Environment:
FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #464 r+26e9c7a-dirty: Fri Jul 13 18:47:11 CEST 2012     fk at r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
multimedia/libdvdread ignores WITH_DEBUG just like multimedia/libdvdnav does (ports/169698). The attached patch fixes this.

I didn't bump PORTREVISION as the default packages shouldn't be affected.

The crash I was investigating turned out to be caused by what I consider a libdvdread API violation in dvdbackup, thus there's no patch for this issue in this PR. I'll submit the fix for dvdbackup once I discussed this with the upstream.
>How-To-Repeat:
1. Build with WITH_DEBUG.
2. Try to debug a crash in libdvdread with gdb.
3. Make a sad face after realizing that there are no symbols.
>Fix:
A fix is attached.

Patch attached with submission follows:

diff -ru .zfs/snapshot/2012-07-07_20:53/multimedia/libdvdread/Makefile multimedia/libdvdread/Makefile
--- .zfs/snapshot/2012-07-07_20:53/multimedia/libdvdread/Makefile	2012-06-13 22:59:40.061127353 +0200
+++ multimedia/libdvdread/Makefile	2012-07-09 21:45:41.642228826 +0200
@@ -28,8 +28,12 @@
 		--shlibdir="${PREFIX}/lib" \
 		--incdir="${PREFIX}/include/dvdread" \
 		--disable-opts \
-		--disable-debug \
 		--cc="${CC}"
+.if defined(WITH_DEBUG)
+CONFIGURE_ARGS+=	--disable-strip
+.else
+CONFIGURE_ARGS+=	--disable-debug
+.endif
 USE_GMAKE=	yes
 USE_LDCONFIG=	yes



>Release-Note:
>Audit-Trail:
>Unformatted: