ports/164242: net/openafs port breaks with KERNCONFDIR and include

[CyberLeo]

>Number:         164242
>Category:       ports
>Synopsis:       net/openafs port breaks with KERNCONFDIR and include
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 17 15:00:22 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     CyberLeo
>Release:        9.0-RELEASE
>Organization:
CyberLeo.Net
>Environment:
FreeBSD testbsd.cyberleo.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0 r229305+66b639e: Mon Jan 16 02:27:17 CST 2012     cyberleo at testbsd.cyberleo.net:/usr/obj/usr/src/sys/TEST  amd64

>Description:
Port installation crashes in post-extract with an out-of-tree configuration file that includes an in-tree configuration file.
>How-To-Repeat:
# mkdir /root/CONFIG
# echo "include GENERIC" > /root/CONFIG/TEST
# make -C /usr/ports/net/openafs KERNCONFDIR=/root/CONFIG KERNCONF=TEST post-extract

/bin/mkdir -p /usr/obj/usr/ports/net/openafs/work/conf
cd /root/CONFIG && /usr/sbin/config -d /usr/obj/usr/ports/net/openafs/work/conf TEST >/dev/null
config: TEST:2: cannot open included file
*** Error code 1

Stop in /usr/ports/net/openafs.

>Fix:
Kernel config step should be executed in the in-tree config directory (KRNLCONFDIR) with an absolute path to the desired config file, as is done in /usr/src/Makefile.inc1 circa line 809 (stage 1: configuring the kernel).

Attached patch applied and tested to compile. Software appears to function properly.

Patch attached with submission follows:

--- ports/net/openafs/Makefile	2012-01-07 17:09:35.000000000 -0600
+++ ports/net/openafs/Makefile	2012-01-17 07:03:44.998004247 -0600
@@ -52,7 +52,8 @@
 .include <bsd.port.pre.mk>
 
 KERNCONF?=	GENERIC
-KERNCONFDIR?=	${SRC_BASE}/sys/${ARCH}/conf
+KRNLCONFDIR=	${SRC_BASE}/sys/${ARCH}/conf
+KERNCONFDIR?=	${KRNLCONFDIR}
 KMODDIR=	/boot/modules
 PLIST_SUB+=	KMODDIR=${KMODDIR:C,^/,,}
 
@@ -97,7 +98,7 @@
 # Do not show users the reminder about cleandepend and depend
 post-extract:
 	${MKDIR} ${WRKDIR}/conf
-	cd ${KERNCONFDIR} && /usr/sbin/config -d ${WRKDIR}/conf ${_KERNCONF} >/dev/null
+	cd ${KRNLCONFDIR} && /usr/sbin/config -d ${WRKDIR}/conf ${KERNCONFDIR}/${_KERNCONF} > /dev/null
 
 create-sample-files:
 	@${ECHO_CMD} openafs.org > ${WRKDIR}/ThisCell


>Release-Note:
>Audit-Trail:
>Unformatted: