ports/165495: over-agressive patchfile in port www/chromium

[Barney Wolff]

>Number:         165495
>Category:       ports
>Synopsis:       over-agressive patchfile in port www/chromium
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 26 23:50:05 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Barney Wolff
>Release:        RELENG7
>Organization:
retired
>Environment:
FreeBSD pit.databus.com 7.4-STABLE FreeBSD 7.4-STABLE #0: Sun Feb 26 00:44:57 EST 2012     toor at pit.databus.com:/usr/obj/usr/src/sys/PIT  i386
>Description:
Port www/chromium has patchfile patch-third_party__WebKit__Source__WebCore__config.h
which has the test: #if __FreeBSD_version < 802502 to #define log2(x) and log2f(x).  But on my
7-stable system, /usr/include/math.h has tagline:
$FreeBSD: src/lib/msun/src/math.h,v 1.62.2.2 2011/10/17 05:38:22 das Exp $
which includes these functions.  The result is a compiler error with both the system gcc and llvm.
>How-To-Repeat:
cd /usr/ports/www/chromium
make all
>Fix:
Removed offending patchfile.  But if there are really systems where it's needed, a finer-grained
test should be substituted.  If chromium won't run on a pre-8 system, that test belongs in the
top-level Makefile.

>Release-Note:
>Audit-Trail:
>Unformatted: