ports/164729: [PATCH] patch editors/nedit to not crash on file->open / file-save

[Mars G Miro]

>Number:         164729
>Category:       ports
>Synopsis:       [PATCH] patch editors/nedit to not crash on file->open / file-save
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 03 07:00:27 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Mars G Miro
>Release:        FreeBSD-9.0-RELEASE/amd64
>Organization:
Organization of Redundant Organizations
>Environment:
FreeBSD spry.XXXXXXXX.XXX 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
editors/nedit crashes when doing either a file->open or file->save:

X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  91 (X_QueryColors)
  Value in failed request:  0xffb3b3b3
  Serial number of failed request:  6525
  Current serial number in output stream:  6525

The exact problem was filed/discussed a loong time ago at:
https://bugzilla.redhat.com/show_bug.cgi?id=199770

for w/c this patch is shamelessly taken ;-)
>How-To-Repeat:
Install editors/nedit. Run nedit. Do file->open or file->save. It will crash nedit. Very annoying.
>Fix:
See patch (shamelessly obtained from RH bugzilla ;-)

Patch attached with submission follows:

--- util/misc.c.visfix	2004-08-10 00:20:00.000000000 +0200
+++ util/misc.c	2006-08-30 13:06:31.000000000 +0200
@@ -384,6 +384,9 @@
 	return (*visual == DefaultVisual(display, screen));
     }
     
+    /* Set "Default" visual to avoid crashes with the detected best ones */
+    reqID = DefaultVisual(display, screen)->visualid;
+    
     /* Read the visualID and installColormap resources for the application.
        visualID can be specified either as a number (the visual id as
        shown by xdpyinfo), as a visual class name, or as Best or Default. */


>Release-Note:
>Audit-Trail:
>Unformatted: