ports/166648: [x11/xterm] Add support for dabbrev-expand

[Oliver Fromme]

>Number:         166648
>Category:       ports
>Synopsis:       [x11/xterm] Add support for dabbrev-expand
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 04 17:00:02 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Fromme
>Release:        any
>Organization:
secnetix GmbH & Co. KG
		http://www.secnetix.de/bsd
>Environment:

	n/a

>Description:

	By default, xterm is not compiled with support for the
	dabbrev-expand function.  (Please refer to the manual
	page to see what this does.  It can be very useful.
	Basically, you can quickly expand words from the xterm
	window with a single keypress, without having to copy
	and paste it with the mouse.)

>How-To-Repeat:

	Assign dabbrev-expand() to a key, as explained in the
	xterm(1) manual page, and try to use it.  It doesn't
	work.

>Fix:

	The patch below adds an option to the port that can be
	used to enable support for dabbrev-expand at compile-
	time.  I chose to set the default for the new option
	to "on" because the function isn't bound to any key by
	default, so it shouldn't hurt anyone.  However, if the
	port maintainer prefers to keep it off by default,
	that would be fine with me, too.

	I've tested this patch, mapped dabbrev-expand to a key
	(in my case the Insert key, though YMMV), and it works
	perfectly well.


--- Makefile.old	2012-01-09 09:34:17.000000000 +0100
+++ Makefile	2012-04-04 18:40:25.000000000 +0200
@@ -26,7 +26,8 @@
 		256_COLOR "enable 256-color support" off \
 		DEC_LOCATOR "enable DECterm Locator support" off \
 		PCRE "use PCRE for regular-expressions" off \
-		GNOME "include gnome support for .desktop file" off
+		GNOME "include gnome support for .desktop file" off \
+		DABBREV "enable support for dabbrev-expand" on
 
 CPPFLAGS+=	-I${LOCALBASE}/include
 
@@ -61,6 +62,10 @@
 PLIST_SUB+=		GNOME="@comment "
 .endif
 
+.if defined(WITH_DABBREV)
+CONFIGURE_ARGS+=	--enable-dabbrev
+.endif
+
 MAN1=		resize.1 koi8rxterm.1 uxterm.1 xterm.1
 
 .include <bsd.port.pre.mk>
>Release-Note:
>Audit-Trail:
>Unformatted: