ports/162456: OpenSSL won't build from ports if x11 excluded from local repository

[Brian C. Ledbetter]

>Number:         162456
>Category:       ports
>Synopsis:       OpenSSL won't build from ports if x11 excluded from local repository
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 02:20:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Brian C. Ledbetter
>Release:        FreeBSD 8.1-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD tokyo.home.shadowcom.net 8.1-RELEASE-p2 FreeBSD 8.1-RELEASE-p2 #5: Mon Jan 24 11:11:25 EST 2011 root at tokyo.home.shadowcom.net:/sr/src/sys/amd64/compile/TOKYO amd64

>Description:
On systems that are configured to exclude the X11 packages from the PORTS repository, building OpnenSSL fails due to a missing xproto dependency.  When this dependency is manually removed, OpenSSL builds and installs successfully.

It might be possible that makedepend is no longer needed to build OpenSSL, and can be removed from its dependency tree.

>How-To-Repeat:
host$ grep x11 /usr/share/examples/cvsup/ports-supfile
#ports-x11
#ports-x11-clocks
#ports-x11-drivers
#ports-x11-fm
#ports-x11-fonts
#ports-x11-servers
#ports-x11-themes
#ports-11-toolkits
#ports-x11-wm

host# cd /usr/ports/security/openssl

host# grep makedepend Makefile
BUILD_DEPENDS=       makedepend:${PORTSDIR}/devel/makedepend

host# make clean all | tail
openssl-1.0.0_6: "/usr/ports/x11/xproto" non-existent -- dependency list incomplete
gnome-config: not found
Package xorg-macros was not found in the pkg-config search path.
Perhaps you should add the directory containing `xorg-macros.pc'
to the PKG_CONFIG_PATH environment variable
No package 'xorg-macros' found
configure: error: Package requirements (xproto) were not met:

gnome-config: not found
No package 'xproto' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables X_CFLAGS
and X_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

/var/db/pkg`).
*** Error code 1

Stop in /usr/ports/devel/makedepend.
*** Error code 1

Stop in /usr/ports/security/openssl.
*** Error code 1

Stop in /usr/ports/security/openssl.

>Fix:
host# vi Makefile
(Comment out BUILD_DEPENDS)

host# grep makedepend Makefile
####BUILD_DEPENDS=       makedepend:${PORTSDIR}/devel/makedepend

host# make clean all
..
cc -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -DL_E
NDIAN -DTERMIOS -O3 -DMD32_REG_T=int -Wall -O2 -pipe -fno-strict-aliasing -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DSHA1_ASM -DSHA256_ASM -DSH
A512_ASM -DMD5_ASM -DAES_ASM -DWHIRLPOOL_ASM -c evp_test.c
cc -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -DL_E
NDIAN -DTERMIOS -O3 -DMD32_REG_T=int -Wall -O2 -pipe -fno-strict-aliasing -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DSHA1_ASM -DSHA256_ASM -DSH
A512_ASM -DMD5_ASM -DAES_ASM -DWHIRLPOOL_ASM -c igetest.c
cc -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -DL_E
NDIAN -DTERMIOS -O3 -DMD32_REG_T=int -Wall -O2 -pipe -fno-strict-aliasing -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DSHA1_ASM -DSHA256_ASM -DSH
A512_ASM -DMD5_ASM -DAES_ASM -DWHIRLPOOL_ASM -c jpaketest.c
cc -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -DL_E
NDIAN -DTERMIOS -O3 -DMD32_REG_T=int -Wall -O2 -pipe -fno-strict-aliasing -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DSHA1_ASM -DSHA256_ASM -DSH
A512_ASM -DMD5_ASM -DAES_ASM -DWHIRLPOOL_ASM -c asn1test.c
cc -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -DL_E
NDIAN -DTERMIOS -O3 -DMD32_REG_T=int -Wall -O2 -pipe -fno-strict-aliasing -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DSHA1_ASM -DSHA256_ASM -DSH
A512_ASM -DMD5_ASM -DAES_ASM -DWHIRLPOOL_ASM -c dummytest.c
making all in tools...

host# make install clean
..

      If there are vulnerabilities in these programs there may be a security
      risk to the system. FreeBSD makes no guarantee about the security of
      ports included in the Ports Collection. Please type 'make deinstall'
      to deinstall the port if this is a concern.

      For more information, and contact details about the security
      status of this software, see the following webpage:
http://www.openssl.org/
===>  Cleaning for openssl-1.0.0_6
--->  Cleaning out obsolete shared libraries


Patch attached with submission follows:

--- Makefile.orig       2011-11-10 21:15:12.000000000 -0500
+++ Makefile    2011-11-08 12:07:41.000000000 -0500
@@ -22,7 +22,7 @@
 PATCH_SITES=   http://sctp.fh-muenster.de/dtls/
 PATCHFILES=    #
 
-BUILD_DEPENDS= makedepend:${PORTSDIR}/devel/makedepend
+###BUILD_DEPENDS=      makedepend:${PORTSDIR}/devel/makedepend
 
 .ifdef USE_OPENSSL
 .error You have `USE_OPENSSL' variable defined either in environment or in make(1) arguments. Please undefine and try again.



>Release-Note:
>Audit-Trail:
>Unformatted: