ports/157130: net-mgmt/collectd BIND plugin dependency check is invalid

[Benjamin Lee]

>Number:         157130
>Category:       ports
>Synopsis:       net-mgmt/collectd BIND plugin dependency check is invalid
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 17 22:30:12 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Benjamin Lee
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD eclipse.b1c1l1.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011     root at almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The BIND plugin for net-mgmt/collectd only uses libcurl and libxml2 to parse BIND XML statistics over HTTP.  This is documented upstream: http://www.collectd.org/wiki/index.php/Plugin:BIND#Dependencies

At some point, the net-mgmt/collectd began checking for the presence of BIND, which is invalid.  Additionally, it no longer registers dependencies against libcurl and libxml2.  The change should be reverted back to the former port behavior.
>How-To-Repeat:

>Fix:
Apply the attached patch.

Patch attached with submission follows:

diff -ruN /usr/ports/net-mgmt/collectd/Makefile collectd/Makefile
--- /usr/ports/net-mgmt/collectd/Makefile	2011-05-16 18:06:46.000000000 -0700
+++ collectd/Makefile	2011-05-17 15:22:51.000000000 -0700
@@ -144,20 +144,11 @@
 .endif
 
 .if defined(WITH_BIND)
-.if ${OSVERSION} < 800000
-BROKEN=		Need bind 9.5+
-.endif
-# check if MK_BIND is set to no (by /etc/src.conf or /etc/make.conf)
-.if exists(${DESTDIR}/usr/lib/libbind9.a) || exists(${LOCALBASE}/lib/libbind9.a)
 CONFIGURE_ARGS+=--enable-bind
+LIB_DEPENDS+=	curl:${PORTSDIR}/ftp/curl
+LIB_DEPENDS+=	xml2:${PORTSDIR}/textproc/libxml2
 PLIST_SUB+=	BIND=""
 .else
-# libind9 does not exists
-CONFIGURE_ARGS+=--disable-bind
-PLIST_SUB+=	BIND="@comment "
-.endif
-.else
-# WITHOUT_BIND
 CONFIGURE_ARGS+=--disable-bind
 PLIST_SUB+=	BIND="@comment "
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted: