ports/156984: www/analog doesn't recognize Chrome browser type properly
Kurt Lidl
kurt.lidl at cello.com
Thu May 12 21:00:19 UTC 2011
>Number: 156984
>Category: ports
>Synopsis: www/analog doesn't recognize Chrome browser type properly
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu May 12 21:00:18 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Kurt Lidl
>Release: FreeBSD 8.2 on x86 (32-bit)
>Organization:
Cello Software, LLC
>Environment:
FreeBSD dev00.cello.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 root at almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Analog has a mode where it collapses the type of browser from the User-Agent
fields into a summary record. It has no knowledge of "Chrome" (or Baiduspider
for that matter). It ends up lumping Chrome into the Safari catagory.
>How-To-Repeat:
Run analog on a web log file, note that Chrome isn't in the "Browser Summary Table" section of the report.
>Fix:
Attached patch extends the diffs found in files/patch-ab to recognise Chrome and Baiduspider as separate type of browsers.
Patch attached with submission follows:
--- src/tree.c.orig 2004-12-19 08:51:31.000000000 -0500
+++ src/tree.c 2011-05-12 16:38:50.388298051 -0400
@@ -769,11 +769,13 @@
if (((*name = strstr(whole, "Mosaic")) != NULL && (len = 6)) ||
((*name = strstr(whole, "mosaic")) != NULL && (len = 6)) ||
((*name = strstr(whole, "Konqueror")) != NULL && (len = 9)) ||
+ ((*name = strstr(whole, "Baiduspider")) != NULL && (len = 11)) ||
((*name = strstr(whole, "Galeon")) != NULL && (len = 6)) ||
((*name = strstr(whole, "Phoenix")) != NULL && (len = 7)) ||
((*name = strstr(whole, "Firebird")) != NULL && (len = 8)) ||
((*name = strstr(whole, "Firefox")) != NULL && (len = 7)) ||
((*name = strstr(whole, "Chimera")) != NULL && (len = 7)) ||
+ ((*name = strstr(whole, "Chrome")) != NULL && (len = 6)) ||
((*name = strstr(whole, "Camino")) != NULL && (len = 6)) ||
((*name = strstr(whole, "Safari")) != NULL && (len = 6)) ||
((*name = strstr(whole, "WebTV")) != NULL && (len = 5)) ||
@@ -904,8 +906,16 @@
*name = "Macintosh";
else if (strstr(whole, "Linux") != NULL || strstr(whole, "linux") != NULL)
*name = "Unix:Linux";
- else if (strstr(whole, "BSD") != NULL)
- *name = "Unix:BSD";
+ else if (strstr(whole, "FreeBSD") != NULL || strstr(whole, "freebsd") != NULL)
+ *name = "Unix:FreeBSD";
+ else if (strstr(whole, "OpenBSD") != NULL || strstr(whole, "openbsd") != NULL)
+ *name = "Unix:OpenBSD";
+ else if (strstr(whole, "NetBSD") != NULL || strstr(whole, "netbsd") != NULL)
+ *name = "Unix:NetBSD";
+ else if (strstr(whole, "BSD/OS") != NULL || strstr(whole, "bsd/os") != NULL)
+ *name = "Unix:BSD/OS";
+ else if (strstr(whole, "BSD") != NULL || strstr(whole, "bsd") != NULL)
+ *name = "Unix:Unknown BSD";
else if (strstr(whole, "SunOS") != NULL || strstr(whole, "sunos") != NULL)
*name = "Unix:SunOS";
else if (strstr(whole, "HP-UX") != NULL || strstr(whole, "HPUX") != NULL ||
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list