ports/156655: [new port] net-mgmt/zenoss: monitoring software

[Chris Rees]

The following reply was made to PR ports/156655; it has been noted by GNATS.

From: Chris Rees <utisoft at gmail.com>
To: jhelfman at e-e.com, bug-followup at freebsd.org, phil at experts-exchange.com
Cc:  
Subject: ports/156655: [new port] net-mgmt/zenoss: monitoring software
Date: Tue, 10 May 2011 20:32:52 +0100

 Hey,
 
 Looks pretty good, it's obvious a load of hard work went into it.
 
 Please don't take this as an attack! A couple of pointers:
 
 #	Only remove conf files that differ from examples
 
 
 It's kinda hard to see what's going on here; you'll be better off with
 something like:
 
 CONF_FILES=  something.conf \
                         something2.conf
 
 then using a Make .for, rather than shell (don't copy/paste this;
 gmail can't do tabs!):
 
 .for file in ${CONF_FILES}
             @cmp ${file} ${file}.example && ${RM} -f ${file} > /dev/null
 .endfor
 
 and you could be better off patching the build scripts to install a
 sample.conf rather than
 
 As I mentioned on IRC, you can't list config files in pkg-plist,
 they'll get wiped out
 by pkg_delete even if they've been edited by a user on
 upgrade/deinstall. Take a look
 at [1].
 
 At the weekend I'll have another look.
 
 Chris
 
 [1] http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html