ports/156747: multimedia/mplayer: fix 24-bits OSS some improvements

[Pan Tsu]

The following reply was made to PR ports/156747; it has been noted by GNATS.

From: Pan Tsu <inyaoo at gmail.com>
To: Zhihao Yuan <lichray at gmail.com>
Cc: bug-followup at freebsd.org
Subject: Re: ports/156747: multimedia/mplayer: fix 24-bits OSS some improvements
Date: Sun, 01 May 2011 16:26:27 +0400

 Zhihao Yuan <lichray at gmail.com> writes:
 
 > In this patch, I just make everything FreeBSD-only (since these macros
 > have different meanings from those in OSS v4).
 
 So, they'd break mplayer with 24bit samples on 4front implementation,
 i.e. audio/oss?
 
 > I have tested the signed 24-bit audio, OK. But I don't have any
 > unsigned audio, since PCM is signed-only.
 
 You can still feed unsigned 24bit samples to ao_oss. For example,
 
   $ mplayer -af format=u24le -msglevel all=-1:ao=9 foo.ogg
   Trying every known audio driver...
   ao2: 44100 Hz  2 chans  u24le
   audio_setup: using '/dev/dsp' dsp device
   audio_setup: using '/dev/mixer' mixer device
   audio_setup: using 'pcm' mixer device
   audio_setup: sample format: u24le (requested: u24le)
   audio_setup: using 2 channels (requested: 2)
   audio_setup: using 44100 Hz samplerate (requested: 44100)
   audio_setup: frags:  32/32  (4092 bytes/frag)  free: 130944
 
 which seems to work fine
 
   $ sysctl hw.snd.verbose=2
   $ fgrep -A3 mplayer /dev/sndstat
           pcm1:play:dsp1.p0[pcm1:virtual:dsp1.vp2]: spd 44100, fmt 0x00240000/0x00201000, flags 0x1000010c, 0x00000023, pid 34306 (mplayer)
           interrupts 0, underruns 0, feed 4810, ready 114660 [b:0/0/0|bs:130944/4092/32]
           channel flags=0x1000010c<RUNNING,TRIGGERED,BUSY,VIRTUAL>
           {userland} -> feeder_root(0x00240000) -> feeder_format(0x00240000 -> 0x00201000) -> feeder_volume(0x00201000) -> {hardware}