ports/155975: [patch] dns/noip: Fix detection of network devices

[David Naylor]

>Number:         155975
>Category:       ports
>Synopsis:       [patch] dns/noip: Fix detection of network devices
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 27 18:20:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     David Naylor
>Release:        FreeBSD-current
>Organization:
Private
>Environment:
FreeBSD dgserver.dg 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Fri Dec 17 19:43:44 SAST 2010     root at dragon.dg:/tmp/home/freebsd9/src/sys/DGSERVER  amd64

>Description:
noip2 fails to detect the network devices, displaying what appears to be a broken list.

The root cause of this is the failed attempt to define bsd_with_getifaddrs as the variable ARCH is used for that purpose and get overridden by ports with the current architecture.  

The attached patch fixes that and also passes ${CFLAGS} to `cc`.  The patch replaces files/patch-Makefile

P.S. Please could the "noip" UID/GID be added to the list?
>How-To-Repeat:
Do:
# cd /usr/ports/dns/noip
# make install conf

Observe the broken list of network devices
>Fix:
Pass -Dbsd_with_getifaddrs explicitly to `cc`.  

Patch attached with submission follows:

--- Makefile.orig	2009-11-17 20:19:54.000000000 +0100
+++ Makefile	2009-11-17 20:22:51.000000000 +0100
@@ -1,8 +1,8 @@
 TGT=noip2
-CC=gcc
+CC?=gcc
 PKG=noip-2.1.tgz
 
-PREFIX=/usr/local
+PREFIX?=/usr/local
 CONFDIR=${PREFIX}/etc
 BINDIR=${PREFIX}/bin
 
@@ -22,7 +22,7 @@
 # ARCH=sun
 
 ${TGT}: Makefile ${TGT}.c 
-	${CC} -Wall -g -D${ARCH} -DPREFIX=\"${PREFIX}\" ${TGT}.c -o ${TGT} ${LIBS}
+	${CC} ${CFLAGS} -Wall -Dbsd_with_getifaddrs -DPREFIX=\"${PREFIX}\" ${TGT}.c -o ${TGT} ${LIBS}
 
 install: ${TGT} 
 	if [ ! -d ${BINDIR} ]; then mkdir -p ${BINDIR};fi


>Release-Note:
>Audit-Trail:
>Unformatted: