ports/155456: security/openssh-portable fails to compile with LPK enabled

[Alexey Remizov]

>Number:         155456
>Category:       ports
>Synopsis:       security/openssh-portable fails to compile with LPK enabled
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 11 08:40:12 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Alexey Remizov
>Release:        FreeBSD-7.3
>Organization:
>Environment:
FreeBSD myhost.org 7.3-i386-20100520 FreeBSD 7.3-i386-20100520 #0: Thu May 20 16:44:53 UTC 2010     /usr/obj/usr/src/sys/KERNEL7-i386  i386

>Description:
After "make":

===>   openssh-portable-5.2.p1_3,1 depends on shared library: ldap-2.4.8 - found
===>  Configuring for openssh-portable-5.2.p1_3,1
env: -DWITH_LDAP_PUBKEY: No such file or directory
===>  Script "configure" failed unexpectedly.
>How-To-Repeat:
cd /usr/ports/security/openssh-portable
make
[select option WITH_LPK]



>Fix:
Looks like port is broken with revision 1.674 of bsd.port.mk. Removing of quotes around CPPFLAGS in openssh-portable/Makefile works for me (see attach).

Patch attached with submission follows:

--- Makefile.orig	2010-12-27 12:58:51.000000000 +0300
+++ Makefile	2011-03-11 11:29:52.000000000 +0300
@@ -151,7 +151,7 @@
 .if defined(WITH_LPK)
 EXTRA_PATCHES+=		${FILESDIR}/contrib-openssh-lpk-5.1p1-0.3.10.patch
 USE_OPENLDAP=		yes
-CPPFLAGS+=		"-I${LOCALBASE}/include -DWITH_LDAP_PUBKEY"
+CPPFLAGS+=		-I${LOCALBASE}/include -DWITH_LDAP_PUBKEY
 CONFIGURE_ARGS+=	--with-libs='-lldap' --with-ldflags='-L${LOCALBASE}/lib' \
 			--with-cppflags='-I${LOCALBASE}/include -DWITH_LDAP_PUBKEY'
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted: