ports/154149: [PATCH] ports-mgmt/portlint: Complain when not using dist/ with CPAN
Steven Kreuzer
skreuzer at FreeBSD.org
Wed Jan 19 22:10:11 UTC 2011
>Number: 154149
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portlint: Complain when not using dist/ with CPAN
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 19 22:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Steven Kreuzer
>Release: FreeBSD 7.3-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD slurry.exit2shell.com 7.3-PRERELEASE FreeBSD 7.3-PRERELEASE #4: Wed Mar 3 11:32:49 EST
>Description:
In pkg-descr, have portlint warn if WWW is equal to something like
http://search.cpan.org/~miyagawa/TheSchwartz-Simple-0.05/ and suggest that it
gets changed to http://search.cpan.org/dist/TheSchwartz-Simple/
Port maintainer (marcus at FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:
--- portlint-2.13.3_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /usr/share/cvs/freebsd/ports/ports-mgmt/portlint/Makefile,v
retrieving revision 1.140
diff -u -u -r1.140 Makefile
--- Makefile 10 Jan 2011 04:43:58 -0000 1.140
+++ Makefile 19 Jan 2011 21:26:55 -0000
@@ -9,6 +9,7 @@
PORTNAME= portlint
PORTVERSION= 2.13.3
+PORTREVISION= 1
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
Index: src/portlint.pl
===================================================================
RCS file: /usr/share/cvs/freebsd/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.118
diff -u -u -r1.118 portlint.pl
--- src/portlint.pl 10 Jan 2011 04:43:58 -0000 1.118
+++ src/portlint.pl 19 Jan 2011 21:27:54 -0000
@@ -636,6 +636,10 @@
&perror("WARN", $file, -1, "WWW URL, $wwwurl should begin ".
"with \"http://\" or \"https://\".");
}
+ if ($wwwurl =~ m|^http://search.cpan.org/~|) {
+ &perror("WARN", $file, -1, "consider changing WWW URL to " .
+ "http://search.cpan.org/dist/$makevar{PORTNAME}");
+ }
}
$linecnt++;
$longlines++ if ($maxchars{$file} < length);
--- portlint-2.13.3_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list