ports/154896: Forbid ${BUILD_DEPENDS} provision in ports-mgmt/portlint

[Joseph S. Atkinson]

>Number:         154896
>Category:       ports
>Synopsis:       Forbid ${BUILD_DEPENDS} provision in ports-mgmt/portlint
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 19 23:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Joseph S. Atkinson
>Release:        
>Organization:
The FreeBSD Project
>Environment:
>Description:
Some maintainers have been including ${BUILD_DEPENDS} to their RUN_DEPENDS sections of their port's Makefile. This has the consequence of forcing these packages to appear to require build only depends such as gmake and libtool.

Also, as a footnote, there is a false positive for direct use of "python" for USE_GSTREAMER. This is, in fact, correct syntax.
>How-To-Repeat:
Here is a list of ports currently affected by the problem:
http://people.freebsd.org/~jsa/share/run_equal_build_ports.txt

Attempt to install some of these via pkg_add and note build tools being pulled in.
>Fix:
A condition should be added to forbid RUN_DEPENDS=${BUILD_DEPENDS} variations from passing portlint(1).

>Release-Note:
>Audit-Trail:
>Unformatted: