ports/163271: [maintainer] [patch] dns/ddclient: rc script fix, add OPTIONS

[Rob Farmer]

>Number:         163271
>Category:       ports
>Synopsis:       [maintainer] [patch] dns/ddclient: rc script fix, add OPTIONS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 14 04:00:28 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Rob Farmer
>Release:        9.0-PRERELEASE
>Organization:
>Environment:
FreeBSD sapphire.predatorlabs.net 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #0 r228449: Mon Dec 12 21:19:24 PST 2011     rfarmer at sapphire.predatorlabs.net:/usr/obj/usr/src/sys/SAPPHIRE  amd64
>Description:
-Remove -daemon 300 from the rc.d script - this overrides the user's value in the configuration file and 300 isn't appropriate for all supported services. If the daemon entry is removed from the config file, the rc script causes it to run once and exit [1]
-Make SSL into a proper OPTION

Reported by: Keith Holman (kholman at gmail.com) [1]
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/dns/ddclient/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- Makefile	28 Jul 2011 21:59:28 -0000	1.28
+++ Makefile	14 Dec 2011 03:42:43 -0000
@@ -7,16 +7,13 @@
 
 PORTNAME=	ddclient
 PORTVERSION=	3.8.1
+PORTREVISION=	1
 CATEGORIES=	dns
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION}
 
 MAINTAINER=	rfarmer at predatorlabs.net
 COMMENT=	Update dynamic DNS entries
 
-.ifndef WITHOUT_SSL
-RUN_DEPENDS=	${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL
-.endif
-
 LICENSE=	GPLv2
 
 USE_BZIP2=	yes
@@ -24,6 +21,14 @@
 NO_BUILD=	yes
 USE_RC_SUBR=	${PORTNAME}
 
+OPTIONS=	SSL "Enable SSL support" ON
+
+.include <bsd.port.options.mk>
+
+.ifndef WITHOUT_SSL
+RUN_DEPENDS+=	${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL
+.endif
+
 SUB_FILES=	pkg-message ddclient_force
 PKGMESSAGE=	${WRKDIR}/pkg-message
 
Index: files/ddclient.in
===================================================================
RCS file: /home/ncvs/ports/dns/ddclient/files/ddclient.in,v
retrieving revision 1.2
diff -u -r1.2 ddclient.in
--- files/ddclient.in	27 Mar 2010 00:12:53 -0000	1.2
+++ files/ddclient.in	14 Dec 2011 03:39:04 -0000
@@ -22,6 +22,6 @@
 load_rc_config ${name}
 
 : ${ddclient_enable="NO"}
-: ${ddclient_flags="-daemon 300"}
+: ${ddclient_flags=""}
 
 run_rc_command "$1"


>Release-Note:
>Audit-Trail:
>Unformatted: