ports/156721: [PATCH] x11-servers/xorg-server Fix bug 24703 EXA crash

[Alexey Shuvaev]

>Number:         156721
>Category:       ports
>Synopsis:       [PATCH] x11-servers/xorg-server Fix bug 24703 EXA crash
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 29 15:20:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Alexey Shuvaev
>Release:        9.0-CURRENT
>Organization:
Technical University of Vienna
>Environment:
FreeBSD lexx.ifp.tuwien.ac.at 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r219713: Thu Mar 17 14:43:00 CET 2011     root at lexx.ifp.tuwien.ac.at:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
The bug when EXA crashes with "exaGetPixmapFirstPixel called for invalid bpp" is most visible with XFCE. One should choose theme Wildbush and Xorg crashes immediately. The xorg-server currently in the ports tree is still affected.
Attached patch should address the problem (pulled from [1]).

[1] http://cgit.freedesktop.org/xorg/xserver/commit/?id=e06fa804009798ea95efa8babaabb0228dfdfe65
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- exa/exa_accel.c.orig	2010-05-04 02:54:14.000000000 +0200
+++ exa/exa_accel.c	2011-04-29 16:54:56.000000000 +0200
@@ -1049,6 +1049,8 @@
 		*(CARD16*)pExaPixmap->sys_ptr = pixel;
 		break;
 	    case 8:
+	    case 4:
+	    case 1:
 		*(CARD8*)pExaPixmap->sys_ptr = pixel;
 	    }
 
--- exa/exa_unaccel.c.orig	2010-05-04 02:47:58.000000000 +0200
+++ exa/exa_unaccel.c	2011-04-29 16:54:56.000000000 +0200
@@ -525,6 +525,8 @@
 	    return pixel;
 	}
     case 8:
+    case 4:
+    case 1:
 	{
 	    CARD8 pixel;
 


>Release-Note:
>Audit-Trail:
>Unformatted: