ports/156367: net/pecl-yaz still BROKEN

[Frank Wall]

Well, I think the pre-configure section in the Makefile
is the reason for this problem. The REINPLACE_CMD seems
to be wrong.

I tried to figure out what happens and did a little 
tracing on the configure script:

/usr/ports/net/pecl-yaz/work/yaz-1.0.14# sh -x configure 2>&1 |grep YAZ
 
+ printf %s\n configure:4054: checking for YAZ support
+ printf %s checking for YAZ support... 
checking for YAZ support... + test  = set
+ PHP_YAZ=no
+ PHP_YAZ=yes
+ printf %s\n #define HAVE_YAZ 1
+ ICU_CPPFLAGS= -I/usr/local/include  -D YAZ_HAVE_ICU=1
+ YAZVERSION=4.1.7
+ YAZLIB=-lyaz
[..]

As you can see, the version information is written to
the YAZVERSION variable, but the REINPLACE_CMD modifies
the configure script to use the YAZ_VERSION variable.

So I suggest to NOT use the REINPLACE_CMD for yaz 4.1.7
and newer. I remember this was introduced with ports/154527 [1].
So this all seems somewhat odd to me.

This patch fixes it for me.

--- net/pecl-yaz/Makefile.orig	2011-03-23 17:45:30.000000000 +0100
+++ net/pecl-yaz/Makefile	2011-04-13 15:34:50.000000000 +0200
@@ -27,7 +27,7 @@
 .include <bsd.port.pre.mk>
 
 pre-configure:
-	@if [ `${PKG_INFO} 'yaz>=4.1.4' > /dev/null 2>&1` ]; then \
+	@if ${PKG_INFO} 'yaz<=4.1.6' > /dev/null 2>&1; then \
 		${REINPLACE_CMD} -e 's|YAZVERSION|YAZ_VERSION|g' \
 				${WRKSRC}/configure; fi


By using this patch configure is happy again:

===>  Configuring for pecl-yaz-1.0.14_3
[...]
checking for PHP extension directory... /usr/local/lib/php/20060613
[...]
checking for YAZ support... yes, shared
checking for YAZ version... 4.1.7
[...]

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154527

Bye
- Frank