ports/150235: sysutils/smartmontools build system bug

[Philip Paeps]

The following reply was made to PR ports/150235; it has been noted by GNATS.

From: Philip Paeps <philip at freebsd.org>
To: Alex Samorukov <samm at os2.kiev.ua>
Cc: Giorgos Keramidas <keramida at freebsd.org>,
	Garrett Wollman <wollman at freebsd.org>, bug-followup at freebsd.org,
	developers at freebsd.org
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Sun, 5 Sep 2010 23:52:12 +0200

 On 2010-09-05 21:30:30 (+0200), Alex Samorukov <samm at os2.kiev.ua> wrote:
 > >> header needs to be installed in /usr/include, end of story.
 > >> -I/usr/src/sys is never acceptable in userland code.
 > >>      
 > > We support building the kernel itself from arbitrary locations, even
 > > using arbitrary OBJDIR locations.  I don't think userland code should
 > > depend on /usr/src or /usr/obj as absolute paths.  They are not part of
 > > the 'published interface' of the kernel and they should never be, as
 > > long as we want to support building e.g. with MAKEOBJDIRPREFIX set to
 > > something like '/home/keramida/work/freebsd/obj.i386'.
 > >    
 > Thats a good point. I can add SRC_BASE variable to the port, with 
 > /usr/src as default. E.g. emulators/rtc do this way.
 
 There is still no guarantee that arbitrary users will have a copy of the
 kernel sources anywhere, or that the copy of the kernel sources they have
 somewhere will match the actual kernel running on the system.
 
 It's also not inconceivable that someone would want to build a port (and/or
 make it a package) on another machine than they one they intend to run it on,
 with different kernel versions on both machines.
 
 Not to make your life difficult, but depending on the kernel source tree is
 not a very good idea.  Is there any particular reason the kernel interfaces
 you're relying on are not in /usr/include?  Maybe arguing for the headers you
 need to be installed and made available to userspace applications would make
 more sense than ensuring your application will break in any of a number of
 cases?
 
  - Philip
 
 -- 
 Philip Paeps                                    Please don't Cc me, I am
 philip at freebsd.org                               subscribed to the list.