ports/151709: [path] tomcat6 rc.d script status command

[Alex Deiter]

>Number:         151709
>Category:       ports
>Synopsis:       [path] tomcat6 rc.d script status command
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 25 05:40:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Alex Deiter
>Release:        8.1-RELEASE
>Organization:
N/A
>Environment:
FreeBSD x4150b.tdc 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010     root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Hi,

status/poll command don't work for www/tomcat6:

# /usr/local/etc/rc.d/tomcat6 start
Starting tomcat60.

# /usr/local/etc/rc.d/tomcat6 status
==>no any output here <==

# /usr/local/etc/rc.d/tomcat6 poll
==>no any output here <==
^C

# /usr/local/etc/rc.d/tomcat6 stop
Stopping tomcat60.
Waiting (max 60 secs) for PIDS: 73398.

Please review small patch for rc.d script.
>How-To-Repeat:
cd /usr/ports/www/tomcat6 && make install
>Fix:
Please review small patch for rc.d script:

# /usr/local/etc/rc.d/tomcat6 start
Starting tomcat60.

# /usr/local/etc/rc.d/tomcat6 status
tomcat60 is running as pid 75572.

# /usr/local/etc/rc.d/tomcat6 poll
Waiting for PIDS: 75572, 75572, 75572, 75572^C

# /usr/local/etc/rc.d/tomcat6 stop
Stopping tomcat60.
Waiting (max 60 secs) for PIDS: 75572.


Patch attached with submission follows:

--- www/tomcat6/files/tomcat6.sh.in.orig	2010-10-25 08:50:37.000000000 +0000
+++ www/tomcat6/files/tomcat6.sh.in	2010-10-25 09:28:07.000000000 +0000
@@ -145,14 +145,21 @@
 		echo "${name} not running? (check $pidfile)."
 		return 1
 	fi
+	echo "${name} is running as pid ${rc_pid}."
 }
 
 tomcat_poll() {
+	_prefix=
 	while (true) ; do
 		rc_pid=$(tomcat_check_pidfile $pidfile)
 		[ -z "$rc_pid" ] && break
+		echo -n ${_prefix:-"Waiting for PIDS: "}$rc_pid
+		_prefix=", "
 		sleep 2
 	done
+	if [ -n "$_prefix" ]; then
+		echo "."
+	fi
 }
 
 tomcat_check_pidfile() {


>Release-Note:
>Audit-Trail:
>Unformatted: