ports/152076: [patch] databases/mysql51-server: Remove lib/mysql/plugin directory when built with BUILD_STATIC knob

[Jarrod Sayers]

>Number:         152076
>Category:       ports
>Synopsis:       [patch] databases/mysql51-server: Remove lib/mysql/plugin directory when built with BUILD_STATIC knob
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 09 13:10:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Jarrod Sayers
>Release:        FreeBSD 7.2-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD manhattan.downtools.com.au 7.2-RELEASE-p4 FreeBSD 7.2-RELEASE-p4 #18: Sat Oct 3 19:20:23 CST 2009 root at manhattan.netleader.com.au:/usr/obj/usr/src/sys/MANHATTAN i386
>Description:
When built with the BUILD_STATIC knob, plugins are compiled statically in to the
mysqld binary, however, the installation process still creates the plugin
directory.  This directory remains empty and is not removed when the package is
deinstalled due to the expansion of %%PLUGINS%% to @comment.

===>  Installing for mysql-server-5.1.52
===>   mysql-server-5.1.52 depends on shared library: mysqlclient.16 - found
===>   Generating temporary packing list
===>  Checking if databases/mysql51-server already installed
===> Creating users and/or groups.
Using existing group `mysql'.
Using existing user `mysql'.
[removed]
Making install in archive
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"
Making install in blackhole
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"
Making install in csv
test -z "/usr/local/lib/mysql" || ../.././install-sh -c -d "/usr/local/lib/mysql"
Making install in federated
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"
Making install in heap
test -z "/usr/local/lib/mysql" || ../.././install-sh -c -d "/usr/local/lib/mysql"
 install  -o root -g wheel -m 444 'libheap.a' '/usr/local/lib/mysql/libheap.a'
 ranlib '/usr/local/lib/mysql/libheap.a'
Making install in innobase
test -z "/usr/local/lib/mysql/plugin" || ../.././install-sh -c -d "/usr/local/lib/mysql/plugin"

Though there is nothing to install in the above output, install-sh appears to
still create the directory.
>How-To-Repeat:
bender#	cd /usr/ports/databases/mysql51-server
bender#	make install clean BUILD_STATIC=YES
bender#	make deinstall
bender#	find /usr/local/lib/mysql/plugin
/usr/local/lib/mysql/plugin
bender#	
>Fix:
Patch supplied.

--- databases-mysql51-server-pkg-plist.diff begins here ---
--- ports/databases/mysql51-server/pkg-plist.orig	2009-10-27 17:38:32.000000000 +1030
+++ ports/databases/mysql51-server/pkg-plist	2010-11-09 22:54:10.000000000 +1030
@@ -169,7 +169,7 @@
 %%NDB%%@dirrm include/mysql/storage/ndb
 %%NDB%%@dirrm include/mysql/storage
 @dirrmtry include/mysql
-%%PLUGINS%%@dirrm lib/mysql/plugin
+ at dirrm lib/mysql/plugin
 @dirrmtry lib/mysql
 @dirrm %%DATADIR%%/charsets
 @dirrm %%DATADIR%%/czech
--- databases-mysql51-server-pkg-plist.diff ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: