ports/146979: editors/emacs configuration ignores "-D WITHOUT_X11"

[Anonymous]

The following reply was made to PR ports/146979; it has been noted by GNATS.

From: Anonymous <swell.k at gmail.com>
To: keramida at freebsd.org (Giorgos Keramidas)
Cc: wahjava at gmail.com (Ashish SHUKLA),  Paul Hoffman <phoffman at proper.com>,  bug-followup at freebsd.org
Subject: Re: ports/146979: editors/emacs configuration ignores "-D WITHOUT_X11"
Date: Thu, 27 May 2010 09:00:22 +0000

 keramida at freebsd.org (Giorgos Keramidas) writes:
 
 > On Wed, 26 May 2010 20:26:14 +0530, wahjava at gmail.com (Ashish SHUKLA) wrote:
 >> [CCing to keramida@ for his inputs, if there any]
 >>
 >> Anonymous  writes:
 >>> SOUND support is not related to X11. It may depend on alsa-lib when it's
 >>> installed but that's all. This should let you build with minimum
 >>> dependencies (only devel/gmake)
 >>
 >> SOUND support doesn't require ALSA on BSDs. It uses OSS, and works great.
 >>
 >> M-x play-sound-file works for me.
 >>
 >> But yes, Thanks for reminding that its not dependent upon X11, and I should
 >> take that WITHOUT_SOUND block from the WITHOUT_X11 block.
 >>
 >>>   $ make WITHOUT_X11= WITHOUT_DBUS= BATCH=
 >>
 >>> I'm not sure what GETTEXT is doing there, though. It's not used by emacs
 >>> directly and is useless for nox11 builds. And this comment gives pretty
 >>> clear answer in which specific case it's needed
 >>
 >> Right, we can take that out, or make that support optional via NLS knob, in
 >> case they later decide to use gettext functionality.
 >
 > Emacs itself doesn't need gettext when it is built without X11.  There
 > are, however, other libraries that Emacs links with which pull gettext
 > as an indirect dependency.
 
 x11: gettext is pulled by gconf2, gtk2, rsvg2 (via gtk2). You can use X11
 with Xaw, Xaw3d or Motif toolkit.
 
 nox11: gettext is not used by DBUS because emacs doesn't depend on glib2 (and
 dbus-glib). BTW, notice `-pthread':
 
   cc -nostdlib `./prefix-args -Xlinker  -L/usr/local/lib -znocombreloc` -Wl,-znocombreloc  -o temacs pre-crt0.o /usr/lib/crt1.o /usr/lib/crti.o dispnew.o frame.o scroll.o xdisp.o menu.o  window.o charset.o coding.o category.o ccl.o character.o chartab.o cm.o term.o terminal.o xfaces.o   dbusbind.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfn s.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o syntax.o unexelf.o bytecode.o process.o callproc.o region-cache.o sound.o atimer.o doprnt.o strftime.o intervals.o textprop.o composite.o md5.o     terminfo.o lastfile.o gmalloc.o  vm-limit.o  mktime.o      -pthread -L/usr/pkg/lib -ldbus-1 -lutil -lncurses    -lm -lgcc -lc -lgcc /usr/lib/crtn.o
   /usr/pkg/lib/libdbus-1.so: undefined reference to `pthread_condattr_destroy'
   /usr/pkg/lib/libdbus-1.so: undefined reference to `pthread_condattr_init'
   /usr/pkg/lib/libdbus-1.so: undefined reference to `pthread_condattr_setclock'
   collect2: ld returned 1 exit status
 
 I guess it expects `-lpthread' not `-pthread' in `pkg-config dbus-1 --libs'
 output.
 
 --- a.diff begins here ---
 Index: editors/emacs/Makefile
 ===================================================================
 RCS file: /a/.cvsup/ports/editors/emacs/Makefile,v
 retrieving revision 1.95
 diff -u -p -r1.95 Makefile
 --- editors/emacs/Makefile	21 May 2010 19:51:04 -0000	1.95
 +++ editors/emacs/Makefile	27 May 2010 08:54:00 -0000
 @@ -219,6 +216,7 @@ BROKEN= Does not currently build with db
  post-patch:
  	@${RM} -f ${WRKSRC}/info/*
  	@${REINPLACE_CMD} -e "s/%%EMACS_VER%%/${EMACS_VER}/g" -e "s/%%DATADIR%%/${DATADIR:C/\//\\\//g}/g" ${WRKSRC}/sources.el
 +	@${REINPLACE_CMD} -e '/^DBUS_LIBS/s/$$/ -lpthread/' ${WRKSRC}/src/Makefile.in
  
  .if defined(WITH_SOURCES)
  post-install:
 --- a.diff ends here ---