ports/147344: [Maintainer] devel/m17n-db: fix the build if NLS is disabled

Nikola Lecic nikola.lecic at anthesphoria.net
Wed Jun 2 20:30:05 UTC 2010


>Number:         147344
>Category:       ports
>Synopsis:       [Maintainer] devel/m17n-db: fix the build if NLS is disabled
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 02 20:30:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Nikola Lecic
>Release:        FreeBSD 8.0-STABLE amd64
>Organization:
>Environment:

System: FreeBSD mordor.xx.ac.rs 8.0-STABLE FreeBSD 8.0-STABLE #0: Fri Feb 26 10:23:40 UTC 2010 nikola at mordor.xx.ac.rs:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

m17n-db configure script always fails if msgfmt doesn't exist, even
with --disable-nls. Therefore it doesn't compile if WITHOUT_NLS is set
(thanks Anonymous for indirectly pointing to this in ports/147123).
There are two ways to correct this behaviour:

(1) to use "CONFIGURE_ENV+= HAVE_MSGFMT=yes" if NLS is _disabled_; it
    gives the expected result (unsuccessful test is not fatal), but it
    looks ugly and counterintuitive in Makefile;

(2) to patch configure and remove unneccessary test.

I think that (2) is cleaner.

To the committer: if you agree with this reasoning, please apply the
attached patch.

The patch adds a new file, files/patch-configure.

>How-To-Repeat:
	
>Fix:

--- m17n-db-1.6.1_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/m17n-db/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile	31 May 2010 01:58:19 -0000	1.22
+++ Makefile	2 Jun 2010 11:49:03 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	m17n-db
 PORTVERSION=	1.6.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	http://www.m17n.org/m17n-lib-download/:m17n \
 		http://anthesphoria.net/FreeBSD/ports/distfiles/:m17n \
Index: files/patch-configure
===================================================================
RCS file: files/patch-configure
diff -N files/patch-configure
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-configure	2 Jun 2010 09:53:24 -0000
@@ -0,0 +1,15 @@
+--- configure~	2010-04-16 11:53:12.000000000 +0000
++++ configure	2010-06-02 09:53:04.000000000 +0000
+@@ -5104,12 +5104,6 @@
+ fi
+ 
+ 
+-if test "x$HAVE_MSGFMT" != "xyes"; then
+-  echo "  Please install the program \"msgfmt\" in advance."
+-  echo "  It is usually included in the package \"gettext\"."
+-  exit 1;
+-else :
+-fi
+ 
+ # Checks for source data files.
+ 
--- m17n-db-1.6.1_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list