ports/153557: patch to warn birtualbox compiler to unsetenv DISPLAY

[Julian Stacey]

>Number:         153557
>Category:       ports
>Synopsis:       patch to warn birtualbox compiler to unsetenv DISPLAY
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 30 17:50:07 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     "Julian Stacey" <jhs at berklix.com>
>Release:        FreeBSD 8.1-RELEASE amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD lapo.js.berklix.net 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Sun Aug 15 12:23:44 CEST 2010 jhs at lapo.js.berklix.net:/usr/src/sys/amd64/compile/LAPO.small amd64

i686 & amd64 & 8.1-RELEASE & current all show the same symptoms

	
>Description:
	I was stuck by this bug till I posted & Bernhard F replied
	unsetenv DISPLAY, so this patch makes it easier for next
	person who gets stuck. It's not an ideal patch:
		- Its noisey,
		- one could add more ifdefs to avoid eg make fetch
		  also being marked as broken, & just leave make all broken.
	But it does the job until someone fixes virtualbox, when the
	patch can then be discarded.
	
>How-To-Repeat:
	setenv DISPLAY your.host.com:0
	cd /usr/ports/emulators/virtualbox-ose ; make
>Fix:
	Patch appended, also copied in 
	http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/emulators/virtualbox-ose/Makefile_DISPLAY_unsetenv.REL=8.1-RELEASE.diff

*** old-8.1-RELEASE-and-current/ports/emulators/virtualbox-ose/Makefile	Fri Dec 24 12:11:35 2010
--- new-generic/ports/emulators/virtualbox-ose/Makefile	Thu Dec 30 17:48:45 2010
***************
*** 20,25 ****
--- 20,30 ----
  MAINTAINER=	vbox at FreeBSD.org
  COMMENT=	A general-purpose full virtualizer for x86 hardware
  
+ test_display != printenv DISPLAY
+ .if ${test_display} != ""
+ BROKEN=		"unsetenv DISPLAY to avoid: Checking for Mesa / GLU: X Error of failed request:  BadRequest (invalid request code or no such operation)"
+ .endif
+ 
  BUILD_DEPENDS=	yasm:${PORTSDIR}/devel/yasm \
  		as86:${PORTSDIR}/devel/dev86 \
  		xsltproc:${PORTSDIR}/textproc/libxslt \
>Release-Note:
>Audit-Trail:
>Unformatted: