ports/153382: apg -y generates segfault

[David Boyd]

>Number:         153382
>Category:       ports
>Synopsis:       apg -y generates segfault
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 22 22:30:11 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     David Boyd
>Release:        7.3-RELEASE-p4
>Organization:
Boyd Consulting Services, LLC
>Environment:
FreeBSD free.bsd1.net 7.3-RELEASE-p4 FreeBSD 7.3-RELEASE-p4 #0: Tue Nov 30 10:25:51 EST 2010     root at free.bsd1.net:/usr/obj/var/cvsup/usr/src/sys/X7SB4  i386

>Description:
apg -y results in segfault.

This appears to be identical to Debian bug #337116 which describes character buffer "salt" as being one byte too small.

I modified apg.c from "char salt[10];" to "char salt[11];" and output appears to be correct.

This problem does not occur with 6.4-RELEASE-p11, but does occur with 8.1-RELEASE-p2.
>How-To-Repeat:
install port security/apg.

run "apg -d -y -n1".
>Fix:
See above description.

>Release-Note:
>Audit-Trail:
>Unformatted: