ports/153296: [PATCH] include pidfile in rc script of databases/mysql51-server

[Steve Wills]

>Number:         153296
>Category:       ports
>Synopsis:       [PATCH] include pidfile in rc script of databases/mysql51-server
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 19 19:10:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Steve Wills
>Release:        8.2-PRERELEASE
>Organization:
>Environment:
>Description:
Recent changes to the rc script for mysql removed the pidfile, causing rc.subr to search for mysqld via name. This causes it to find mysql processes it shouldn't find, such as those running outside or inside a chroot or those created by akonadi. Putting the pidfile back fixes it.
>How-To-Repeat:
deinstall mysql while running kde4 and/or inside a ports tinderbox
>Fix:
See attached patch

Patch attached with submission follows:

Index: files/mysql-server.sh.in
===================================================================
RCS file: /home/ncvs/ports/databases/mysql51-server/files/mysql-server.sh.in,v
retrieving revision 1.9
diff -u -r1.9 mysql-server.sh.in
--- files/mysql-server.sh.in	16 Dec 2010 08:27:58 -0000	1.9
+++ files/mysql-server.sh.in	19 Dec 2010 16:53:52 -0000
@@ -37,6 +37,7 @@
 
 mysql_user="mysql"
 mysql_limits_args="-e -U ${mysql_user}"
+pidfile=${mysql_pidfile}
 command="/usr/sbin/daemon"
 command_args="-c -f %%PREFIX%%/bin/mysqld_safe --defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${mysql_pidfile} ${mysql_args}"
 procname="%%PREFIX%%/libexec/mysqld"


>Release-Note:
>Audit-Trail:
>Unformatted: