ports/153159: audio/sox: play fails to start

[Dan Nelson]

The following reply was made to PR ports/153159; it has been noted by GNATS.

From: Dan Nelson <dnelson at allantgroup.com>
To: bug-followup at FreeBSD.ORG
Cc:  
Subject: Re: ports/153159: audio/sox: play fails to start
Date: Wed, 15 Dec 2010 09:48:39 -0600

 --0F1p//8PRICkK4MW
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 
 The attached patch should fix the problem (I used audio/xmp's Makefile as a
 template).
 
 Any port committer that wants to commit this, please use the following log
 entry:
 
 ===
 
 Sox will use alsa-lib if it finds it and isn't told not to use it, so add an
 optional dependency on it, defaulting to off.  Bump portrevision to repair
 any installed sox binaries that might be broken due to the unreported
 dependency.
 
 ===
 
 -- 
 	Dan Nelson
 	dnelson at allantgroup.com
 
 --0F1p//8PRICkK4MW
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="sox.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/audio/sox/Makefile,v
 retrieving revision 1.51
 diff -u -r1.51 Makefile
 --- Makefile	12 Dec 2010 16:51:50 -0000	1.51
 +++ Makefile	15 Dec 2010 15:21:01 -0000
 @@ -7,7 +7,7 @@
  
  PORTNAME=	sox
  PORTVERSION=	14.3.0
 -PORTREVISION=	6
 +PORTREVISION=	7
  CATEGORIES=	audio
  MASTER_SITES=	SF
  
 @@ -32,7 +32,8 @@
  _LAME=	on
  .endif
  
 -OPTIONS=	AO "Enable libao output" on \
 +OPTIONS=	ALSA "ALSA output driver" off \
 +		AO "Enable libao output" on \
  		AMRNB "AMR Speech Codec (Narrowband)" off \
  		AMRWB "AMR Speech Codec (Wideband)" off \
  		FFMPEG "Enable ffmpeg en/decoding" on \
 @@ -55,6 +56,14 @@
  CONFIGURE_ARGS+=	--with-pkgconfigdir="${PREFIX}/libdata/pkgconfig"
  CONFIGURE_ARGS+=	--with-distro="${CONFIGURE_TARGET} ${PKGNAME}"
  
 +.if defined(WITH_ALSA)
 +LIB_DEPENDS+=		asound.2:${PORTSDIR}/audio/alsa-lib
 +RUN_DEPENDS+=		${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:${PORTSDIR}/audio/alsa-plugins
 +CONFIGURE_ARGS+=	--with-alsa
 +.else
 +CONFIGURE_ARGS+=	--without-alsa
 +.endif
 +
  .if defined(WITH_AO)
  CONFIGURE_ARGS+=	--with-ao
  LIB_DEPENDS+=		ao.4:${PORTSDIR}/audio/libao
 
 --0F1p//8PRICkK4MW--