ports/153001: 2 ports hang on fetch, IS_INTERACTIVE is wrongly ifdefd

[Julian H. Stacey]

>Number:         153001
>Category:       ports
>Synopsis:       2 ports hang on fetch, IS_INTERACTIVE is wrongly ifdefd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 10 19:06:13 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Julian H. Stacey <jhs at berklix.com>
>Release:        FreeBSD 8.0-RELEASE amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Mon Jul 12 00:59:43 CEST 2010 jhs at fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64


	
>Description:
	
/usr/ports/emulators/
	vmware-guestd5  
	vmware-guestd6 
hang on 
	make fetch BATCH=YES
because 
	IS_INTERACTIVE
is wrongly protected by preceeding ifdef

>How-To-Repeat:
	
	cd /usr/ports/emulators/
		vmware-guestd5
        	vmware-guestd6
	make fetch BATCH=YES


>Fix:

	
Apply patches appended, from what will be in 
	http://berklix.com/~jhs/src/bsd/fixes/freebsd/ports/gen/emulators/vmware-guestd5/Makefile.REL=8.1_RELEASE.diff
	http://berklix.com/~jhs/src/bsd/fixes/freebsd/ports/gen/emulators/vmware-guestd6/Makefile.REL=8.1_RELEASE.diff

PS Yes the ## lines dont need to exist at all.
----------
*** old/ports/emulators/vmware-guestd5/Makefile	Fri Dec 10 17:48:26 2010
--- new-generic-8.1-RELEASE/ports/emulators/vmware-guestd5/Makefile	Fri Dec 10 17:54:18 2010
*** Makefile.orig	Fri Dec 10 17:48:26 2010
--- Makefile	Fri Dec 10 18:41:25 2010
***************
*** 27,35 ****
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! .endif
  .if defined(VMWARE_X_PORTS)
  USE_XORG=	x11
  NO_BUILD=	yes
--- 27,35 ----
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! ## .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! ## .endif
  .if defined(VMWARE_X_PORTS)
  USE_XORG=	x11
  NO_BUILD=	yes
----------
*** old/ports/emulators/vmware-guestd6/Makefile	Fri Dec 10 17:48:32 2010
--- new-generic-8.1-RELEASE/ports/emulators/vmware-guestd6/Makefile	Fri Dec 10 17:54:16 2010
***************
*** 25,33 ****
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! .endif
  
  RESTRICTED=	"Not sure if we can redistribute this."
  NO_PACKAGE=	${RESTRICTED}
--- 25,33 ----
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! ## .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! ## .endif
  
  RESTRICTED=	"Not sure if we can redistribute this."
  NO_PACKAGE=	${RESTRICTED}
----------
>Release-Note:
>Audit-Trail:
>Unformatted: