ports/152739: [PATCH] databases/mysql51-server: introduce $mysql_pidfile

[Frank Wall]

>Number:         152739
>Category:       ports
>Synopsis:       [PATCH] databases/mysql51-server: introduce $mysql_pidfile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 01 11:00:22 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Frank Wall
>Release:        7.1-RELEASE-p11
>Organization:
>Environment:
FreeBSD 7.1-RELEASE-p11 FreeBSD 7.1-RELEASE-p11 #0: Fri Feb 26 19:22:31 UTC 2010     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The patch makes it possible to set $mysql_pidfile through /etc/rc.conf.

Currently the mysql-server RC script always uses ${mysql_dbdir}/`/bin/hostname`.pid for pidfile. In same cases this could be a bad idea. This patch allows to change the default value.

>How-To-Repeat:
-
>Fix:
apply the patch

Patch attached with submission follows:

--- databases/mysql51-server/files/mysql-server.sh.in.orig	2010-12-01 11:49:36.000000000 +0100
+++ databases/mysql51-server/files/mysql-server.sh.in	2010-12-01 11:50:29.000000000 +0100
@@ -16,6 +16,8 @@
 #			just before mysql starts.
 # mysql_dbdir (str):	Default to "/var/db/mysql"
 #			Base database directory.
+# mysql_pidfile (bool):	default: ${mysql_dbdir}/`/bin/hostname`.pid
+#			Set to the full path of the pid file
 # mysql_args (str):	Custom additional arguments to be passed
 #			to mysqld_safe (default empty).
 #
@@ -30,13 +32,13 @@
 : ${mysql_enable="NO"}
 : ${mysql_limits="NO"}
 : ${mysql_dbdir="/var/db/mysql"}
+: ${mysql_pidfile="${mysql_dbdir}/`/bin/hostname`.pid"}
 : ${mysql_args=""}
 
 mysql_user="mysql"
 mysql_limits_args="-e -U ${mysql_user}"
-pidfile="${mysql_dbdir}/`/bin/hostname`.pid"
 command="/usr/sbin/daemon"
-command_args="-c -f %%PREFIX%%/bin/mysqld_safe --defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${pidfile} ${mysql_args}"
+command_args="-c -f %%PREFIX%%/bin/mysqld_safe --defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${mysql_pidfile} ${mysql_args}"
 procname="%%PREFIX%%/libexec/mysqld"
 start_precmd="${name}_prestart"
 start_postcmd="${name}_poststart"


>Release-Note:
>Audit-Trail:
>Unformatted: