ports/149218: shells/bash is missing dependency on libiconv if WITHOUT_NLS is set

[Yar Tikhiy]

>Number:         149218
>Category:       ports
>Synopsis:       shells/bash is missing dependency on libiconv if WITHOUT_NLS is set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 03 02:30:05 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Yar Tikhiy
>Release:        8.1-RELEASE
>Organization:
BarNetwork P/L
>Environment:
PORTNAME=               bash
PATCHLEVEL=             7
PORTVERSION=            4.1.${PATCHLEVEL:S/^0//g}
PORTREVISION?=          0

>Description:
The shells/bash port is missing an explicit dependency on libiconv -- see its Makefile.  If it's built with all defaults, libiconv is pulled in indirectly through gettext.  However, if NLS support is turned off for bash, libiconv isn't pulled in at all and bash fails to link unless libiconv was installed for other ports.

Otherwise, if libiconv is already there and so bash installs OK, libiconv's +REQUIRED_BY doesn't list bash, which can break a recursive port upgrade later.
>How-To-Repeat:
# portsnap fetch update
# cd /usr/ports/shells/bash
# make install WITHOUT_NLS=1
[...]
rm -f bash
cc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob  -L./lib/tilde  -L./lib/sh -L/usr/local/lib    -O2 -pipe -fno-strict-aliasing -o bash shell.o eval.o y.tab.o general.o make_cmd.o print_cmd.o   dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o  expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o  trap.o input.o unwind_prot.o pathexp.o sig.o test.o version.o  alias.o array.o arrayfunc.o assoc.o braces.o bracecomp.o bashhist.o  bashline.o  list.o stringlib.o locale.o findcmd.o redir.o  pcomplete.o pcomplib.o syntax.o xmalloc.o  -lbuiltins -lglob -lsh -lreadline -lhistory -ltermcap  -ltilde   -liconv
/usr/bin/ld: cannot find -liconv
*** Error code 1

Stop in /usr/ports/shells/bash/work/bash-4.1.
*** Error code 1

Stop in /usr/ports/shells/bash.

>Fix:
Expressly list a dependency on libiconv in ports/shells/bash/Makefile:

USE_ICONV=      yes


>Release-Note:
>Audit-Trail:
>Unformatted: