ports/139116: bsd.port.mk: call target "install-rc-script" before "post-install"

[Sergey Skvortsov]

>Number:         139116
>Category:       ports
>Synopsis:       bsd.port.mk: call target "install-rc-script" before "post-install"
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 24 15:00:11 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Sergey Skvortsov
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 7.2-STABLE FreeBSD 7.2-STABLE #39 r196005: Fri Jul 31 21:51:38 UTC 2009 simon at freefall.freebsd.org:/usr/src/sys/i386/compile/FREEFALL i386


>Description:

In _INSTALL_SUSEQ order of targets is incorrect: "install-rc-script" must
be placed before "post-install". (Or "post-install post-install-script" must be
placed after "install-ldconfig-file".)

This is important because POST-INSTALL script may call rc.d-script for some purposes.
For example, configs tests generation, performing checks and so on. This actions may be
added as "extra_commands" info rc.d-script.

Note that this issue is occured only when we install from ports.
Adding binary package all is ok, because script +POST-INSTALL is running
after placing package files to the final location.

So we have inconsistent behaviour.
 
>How-To-Repeat:
>Fix:

--- bsd.port.mk.orig    2009-09-24 14:35:37.000000000 +0000
+++ bsd.port.mk 2009-09-24 14:37:48.000000000 +0000
@@ -4283,9 +4283,9 @@
 				pre-install-script generate-plist check-already-installed
 _INSTALL_SUSEQ= check-umask install-mtree pre-su-install \
 				pre-su-install-script create-users-groups do-install \
-				install-desktop-entries post-install post-install-script \
-				add-plist-info add-plist-docs add-plist-examples add-plist-data \
-				add-plist-post install-rc-script compress-man \
+				install-desktop-entries install-rc-script post-install post-install-script \
+				add-plist-info add-plist-docs add-plist-examples \
+				add-plist-data add-plist-post compress-man \
 install-ldconfig-file fake-pkg security-check
 _PACKAGE_DEP=	install
 _PACKAGE_SEQ=	package-message pre-package pre-package-script \



>Release-Note:
>Audit-Trail:
>Unformatted: