ports/140855: Port gpstk: reading dual frequency NovaTel data, buffer overflow

[IPS FreeBSD]

>Number:         140855
>Category:       ports
>Synopsis:       Port gpstk: reading dual frequency NovaTel data, buffer overflow
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 25 03:10:04 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     IPS IT Services
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
IPS Radio and Space Services
>Environment:
System: FreeBSD qayaq 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Fri Oct 9 08:09:41 EST 2009 root at qayaq:/usr/obj/usr/src/sys/CT i386

FreeBSD five 7.2-STABLE FreeBSD 7.2-STABLE #0: Fri Oct 16 12:02:25 EST 2009     root at five:/usr/obj/usr/src/sys/FIVE  i386

port astro/gpstk (v1.5)

	
>Description:

Reading dual frequency NovaTel OEM4 range data fails when number of SV's >=12 due
to insufficient buffer size.
ie. Two range records (L1 & L2) are produced for each SV which exceeds buffer allocated for 
12 SV
	
>How-To-Repeat:

Turn on debug in NovatelData.cpp, recompile and read appropriate data file with novaRINEX.
	
>Fix:

Increased size of buffer in NovatelData.hpp
Used sizeof and corrected determining if a buffer overrun will occur for OEM2 and
OEM4 receivers in NovatelData.cpp.

Patch files attached.

This patch should also work with gpstk v1.6

	


>Release-Note:
>Audit-Trail:
>Unformatted: