ports/140432: net/pptpclient 1.7.2_3 is broken

[Matthew Luckie]

>Number:         140432
>Category:       ports
>Synopsis:       net/pptpclient 1.7.2_3 is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 09 20:40:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Luckie
>Release:        FreeBSD 7.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD spandex.luckie.org.nz 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Mon Jul 27 19:48:00 NZST 2009 root at spandex.luckie.org.nz:/usr/src/sys/i386/compile/spandex i386

Ports are up to date as of now.

>Description:

When I updated net/pptpclient from 1.7.2_2 to 1.7.2_3 it stopped working.
Downgrading back to 1.7.2_2 works fine.

I use pptpclient as follows:

/usr/local/sbin/pptp 192.168.0.2 adsl

where adsl is a ppp label that handles login to my adsl provider.

ppp.conf as follows:

default:
 set log Phase Chat LCP IPCP CCP tun command
 ident user-ppp VERSION (built COMPILATIONDATE)

adsl:
 set authname foo 
 set authkey bar 
 set timeout 0
 set ifaddr 0 0
 #enable dns
 add default HISADDR

/var/log/messages when pptp is broken 1.7.2_3:

Nov 10 08:09:27 spandex pptp[1534]: anon log[main:pptp.c:314]: The synchronous pptp option is NOT activated
Nov 10 08:09:27 spandex pptp[1542]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 1 'Start-Control-Connection-Request'
Nov 10 08:09:27 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:739]: Received Start Control Connection Reply
Nov 10 08:09:27 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:773]: Client connection established.
Nov 10 08:09:28 spandex pptp[1542]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 7 'Outgoing-Call-Request'
Nov 10 08:09:28 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:858]: Received Outgoing Call Reply.
Nov 10 08:09:28 spandex pptp[1534]: anon fatal[main:pptp.c:361]: Could not launch pppd
Nov 10 08:09:28 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:897]: Outgoing call established (call ID 0, peer's call ID 0).
Nov 10 08:09:30 spandex pptp[1543]: anon warn[decaps_hdlc:pptp_gre.c:204]: short read (0): Invalid argument
Nov 10 08:09:30 spandex pptp[1542]: anon log[callmgr_main:pptp_callmgr.c:234]: Closing connection (unhandled)
Nov 10 08:09:30 spandex pptp[1542]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 12 'Call-Clear-Request'
Nov 10 08:09:30 spandex pptp[1542]: anon log[call_callback:pptp_callmgr.c:79]: Closing connection (call state)

/var/log/messages when pptp is fixed 1.7.2_2:

Nov 10 08:29:46 spandex pptp[3272]: anon log[main:pptp.c:314]: The synchronous pptp option is NOT activated
Nov 10 08:29:46 spandex pptp[3280]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 1 'Start-Control-Connection
-Request'
Nov 10 08:29:46 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:739]: Received Start Control Connection Reply
Nov 10 08:29:46 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:773]: Client connection established.
Nov 10 08:29:47 spandex pptp[3280]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 7 'Outgoing-Call-Request'
Nov 10 08:29:47 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:858]: Received Outgoing Call Reply.
Nov 10 08:29:47 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:897]: Outgoing call established (call ID 0, peer's call ID 0
).
Nov 10 08:29:51 spandex ppp[3272]: tun0: Warning: 0.0.0.0/0: Change route failed: errno: No such process
Nov 10 08:29:51 spandex ppp[3272]: tun0: Warning: ff02:5::/32: Change route failed: errno: Network is unreachable
Nov 10 08:30:37 spandex pptp[3280]: anon log[logecho:pptp_ctrl.c:677]: Echo Request received.
Nov 10 08:30:37 spandex pptp[3280]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 6 'Echo-Reply'

>How-To-Repeat:

Upgrade from 1.7.2_2 to 1.7.2_3

>Fix:

Downgrade to 1.7.2_2


>Release-Note:
>Audit-Trail:
>Unformatted: