ports/136625: databases/postgresql84-server defaults to 32bit date/time

[Richard Tector]

>Number:         136625
>Category:       ports
>Synopsis:       databases/postgresql84-server defaults to 32bit date/time
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 09 17:30:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Richard Tector
>Release:        
>Organization:
>Environment:
FreeBSD moses.thekeelecentre.com 7.2-STABLE FreeBSD 7.2-STABLE #0: Wed Jun 10 18:24:51 BST 2009     richard at moses.thekeelecentre.com:/usr/obj/usr/src/sys/MOSES  amd64
>Description:
PostgreSQL 8.4 now defaults to using a 64bit date/time field: http://www.postgresql.org/docs/8.4/static/release-8-4.html#AEN94019

This both fixes the build option (now --disable-integer-datetime) and sets the default to enabled, as per the standard Postgres build.

Users moving from 8.3 to 8.4 must dump/restore their databases in any case, so datafile compatibility should not be an issue. Furthermore, I believe that those users who have already made the switch should not have a problem since they will have 64 bit datetimes already, the old build option being ignored.
>How-To-Repeat:

>Fix:
See attached.

Patch attached with submission follows:

--- Makefile.old        2009-07-09 17:58:00.000000000 +0100
+++ Makefile    2009-07-09 18:11:58.000000000 +0100
@@ -100,7 +100,7 @@

 # See http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/76999 for more info
 # (requires dump/restore if modified.)
-OPTIONS+=      INTDATE "Builds with 64-bit date/time type (server)" off
+OPTIONS+=      INTDATE "Builds with 64-bit date/time type (server)" on

 #.  if (defined(SERVER_ONLY) && defined(WITH_ICU)) || make(makesum)
 #USE_AUTOTOOLS=        autoconf:262
@@ -133,8 +133,8 @@
 PLIST_SUB+=    TZDATA="@comment "
 .  endif

-.  if defined(WITH_INTDATE)
-CONFIGURE_ARGS+=--enable-integer-datetimes
+.  if defined(WITHOUT_INTDATE)
+CONFIGURE_ARGS+=--disable-integer-datetimes
 .  endif

 .  if !(defined(WITHOUT_GETTEXT) || defined(WITHOUT_NLS))



>Release-Note:
>Audit-Trail:
>Unformatted: