ports/130529: lang/perl5.8 build fails

[Shin-ichi Yoshimoto]

>Number:         130529
>Category:       ports
>Synopsis:       lang/perl5.8 build fails
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 14 05:30:04 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Shin-ichi Yoshimoto
>Release:        FreeBSD 8.0-CURRENT
>Organization:
>Environment:
FreeBSD current.localdomain 8.0-CURRENT FreeBSD 8.0-CURRENT #7: Tue Jan 13 09:21:06 JST 2009     yosimoto at current.localdomain:/usr/obj/usr/src/sys/MYKERNEL  amd64
>Description:
A build of lang/perl5.8 on 14 Jan 2009 (fresh cvsup) fails as follows:

# make showconfig
===> The following configuration options are available for perl-threaded-5.8.9:
     DEBUGGING=off "Build with debugging support"
     GDBM=off "Build GDBM_File extension"
     PERL_MALLOC=on "Use Perl malloc"
     PERL_64BITINT=on "Use 64 bit integers (on i386)"
     THREADS=on "Build threaded perl"
     SUIDPERL=off "Build set-user-id suidperl binary"
     SITECUSTOMIZE=off "Run-time customization of @INC"
     USE_PERL=on "Rewrite links in /usr/bin"
===> Use 'make config' to modify these settings

# make
===>  Vulnerability check disabled, database not found
===>  Found saved configuration for perl-threaded-5.8.9
===>  Extracting for perl-threaded-5.8.9
=> MD5 Checksum OK for perl/perl-5.8.9.tar.bz2.
=> SHA256 Checksum OK for perl/perl-5.8.9.tar.bz2.
=> MD5 Checksum OK for perl/BSDPAN-5.8.9.tar.bz2.
=> SHA256 Checksum OK for perl/BSDPAN-5.8.9.tar.bz2.
=> MD5 Checksum OK for perl/defined-or-5.8.9.bz2.
=> SHA256 Checksum OK for perl/defined-or-5.8.9.bz2.
===>  Patching for perl-threaded-5.8.9
===>  Applying distribution patches for perl-threaded-5.8.9
===>  Applying FreeBSD patches for perl-threaded-5.8.9

(snip)

`sh  cflags "optimize='-O2 -pipe -fno-strict-aliasing'" sv.o` -DPIC -fPIC sv.c
	  CCCMD =  cc -DPERL_CORE -c -DAPPLLIB_EXP="/usr/local/lib/perl5/5.8.9/BSDPAN" -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -I/usr/local/include  -std=c89 -O2 -pipe -fno-strict-aliasing  -Wall -ansi -pedantic -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wc++-compat -DPERL_GCC_PEDANTIC 
sv.c: In function 'Perl_sv_2pv_flags':
sv.c:2660: warning: value computed is not used
sv.c: In function 'Perl_sv_dup':
sv.c:9817: warning: ordered comparison of pointer with integer zero
sv.c:9817: error: invalid type argument of '->'
sv.c:9817: error: expected ')' before '{' token
sv.c:9901: error: expected expression before '}' token
*** Error code 1

Stop in /usr/ports/lang/perl5.8/work/perl-5.8.9.
*** Error code 1

Stop in /usr/ports/lang/perl5.8.
*** Error code 1

Stop in /usr/ports/lang/perl5.8.



>How-To-Repeat:
cd /usr/ports/lang/perl5.8
make
>Fix:
# diff -u files/patch-sv.c.orig files/patch-sv.c
--- files/patch-sv.c.orig	2009-01-14 06:38:50.000000000 +0900
+++ files/patch-sv.c	2009-01-14 13:59:30.000000000 +0900
@@ -6,7 +6,7 @@
  	    case SVt_PVAV:
 -		if (AvARRAY((AV*)sstr)) {
 +		/* avoid cloning an empty array */
-+		if (AvARRAY((AV*)sstr) && AvFILLp((AV*)sstr >= 0) {
++		if (AvARRAY((AV*)sstr) && AvFILLp((AV*)sstr) >= 0) {
  		    SV **dst_ary, **src_ary;
  		    SSize_t items = AvFILLp((AV*)sstr) + 1;

>Release-Note:
>Audit-Trail:
>Unformatted: