ports/141785: deskutils/google-gadgets: fix Qt4 usage

[Max Brazhnikov]

>Number:         141785
>Category:       ports
>Synopsis:       deskutils/google-gadgets: fix Qt4 usage
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 19 20:40:03 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Max Brazhnikov
>Release:        FreeBSD 8.0-STABLE i386
>Organization:
>Environment:
FreeBSD luna.dio.ru 8.0-STABLE FreeBSD 8.0-STABLE #2: Fri Dec  4 17:55:41 MSK 2009     makc at luna.dio.ru:/usr/obj/usr/freebsd/8/src/sys/LUNA  i386
>Description:
1) USE_* must be used before bsd.port.pre.mk (see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html#AEN2441 ), fix this
2) improve IGNORE message
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: ports/deskutils/google-gadgets/Makefile
===================================================================
RCS file: /home/pcvs/ports/deskutils/google-gadgets/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- ports/deskutils/google-gadgets/Makefile	2 Aug 2009 19:32:54 -0000	1.13
+++ ports/deskutils/google-gadgets/Makefile	19 Dec 2009 19:34:03 -0000
@@ -48,10 +48,16 @@
 		GTK		"Build GTK Host"			on\
 		QT		"Build Qt Host"				on
 
+.include <bsd.port.options.mk>
+.if defined(WITH_QT)
+USE_QT_VER=	4
+QT_COMPONENTS=	webkit opengl gui corelib script network moc_build
+.endif
+
 .include <bsd.port.pre.mk>
 
 .if ${OSVERSION} < 700000
-IGNORE=This port needs 7.X or higher
+IGNORE=	needs 7.X or higher
 .endif
 
 .if defined(WITH_DEBUGGING)
@@ -74,14 +80,12 @@
 CONFIGURE_ARGS+=	--disable-qt-host --disable-libggadget-qt --disable-qt-system-framework\
 			--disable-qtwebkit-browser-element --disable-qt-script-runtime --disable-qt-xml-http-request
 .else
-USE_QT_VER=	4
-QT_COMPONENTS=	webkit opengl gui corelib script network moc
 PLIST_SUB+=	QT=""
 CONFIGURE_ARGS+=	--enable-qt-host
 .endif
 
 .if defined(WITHOUT_QT) && defined(WITHOUT_GTK)
-IGNORE=This port requires GTK or Qt host to be enabled
+IGNORE=	requires GTK or/and Qt host to be enabled. Please, rerun 'make config'
 .endif
 
 post-patch:


>Release-Note:
>Audit-Trail:
>Unformatted: