ports/138056: multimedia/ogle: buggy pre-configure

[Kalten]

>Number:         138056
>Category:       ports
>Synopsis:       multimedia/ogle: buggy pre-configure
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 21 22:40:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Kalten
>Release:        7.2-STABLE (702105)
>Organization:
>Environment:
FreeBSD freeHugin.Walhalla.Leben 7.2-STABLE FreeBSD 7.2-STABLE #0: Thu Aug 20 02:54:05 UTC 2009     root at freeHugin.Walhalla.Leben:/usr/obj/usr/src/sys/HUGIN  i386
>Description:
csup of system at 20.Aug 2009,
csup of ports  at 20.Aug 2009 (no ports build before that)
# $FreeBSD: ports/multimedia/ogle/Makefile,v 1.46 2009/08/02 19:34:51 mezz Exp $

when compiling (not in a TB?) the pre-configure generates faulty entries in the "configure" file.  It inserts a little bit too much from ${LOCALBASE}/lib/liba52.la as it insert a part of a comment. The comments must be greped away (see patch)!!! or configure will fale with what was generated at "hack to make ogle work with liba52 + djbfft".

---SCHNIPP--- part from my ${LOCALBASE}/lib/liba52.la
# Linker flags that can not go in dependency_libs.
inherited_linker_flags=''

# Libraries that this one depends upon.
dependency_libs=' -L/usr/local/lib -ldjbfft -lm'
---schnapp---

it greps out
---SCHNIPP--- grep dependency_libs ${LOCALBASE}/lib/liba52.la | cut -d \' -f 2
# Linker flags that can not go in dependency_libs.
 -L/usr/local/lib -ldjbfft -lm
---schnapp---
instead of just the last line. Because of that, configure tries to compile a file called "#" and so on.
>How-To-Repeat:
make
>Fix:
Error in /usr/ports/multimedia/ogle/Makfile
Appended patch-file helps.

Patch attached with submission follows:

--- Makefile.orig	2009-08-20 02:43:53.000000000 +0200
+++ Makefile	2009-08-22 00:01:10.000000000 +0200
@@ -65,7 +65,7 @@
 
 # hack to make ogle work with liba52 + djbfft
 .if exists(${LOCALBASE}/lib/liba52.la)
-LIBA52_DEP_LIBS!=	${GREP} dependency_libs ${LOCALBASE}/lib/liba52.la | ${CUT} -d \' -f 2
+LIBA52_DEP_LIBS!=	${GREP} dependency_libs ${LOCALBASE}/lib/liba52.la | ${GREP} -v ^"[ \t]*#" | ${CUT} -d \' -f 2
 .else
 LIBA52_DEP_LIBS=
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted: