ports/133954: git help uses wrong MANPATH

[Tony Finch]

>Number:         133954
>Category:       ports
>Synopsis:       git help uses wrong MANPATH
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 23 18:00:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Tony Finch
>Release:        7.1-RELEASE
>Organization:
>Environment:
FreeBSD black.csi.cam.ac.uk 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan  1 14:37:25 UTC 2009     root at logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
"git help" sets the MANPATH environment variable to ensure that it includes the path to git's man pages before invoking man. Its build system's man path is ${PREFIX}/share/man but the FreeBSD port installs them in /usr/local/man. Therefore git adds an incorrect entry to the MANPATH. If the user did not have a MANPATH set then the new path set by git overrides /etc/manpath.config, so man can no longer find the desired page. In this situation git includes a trailing : in order to make man on Linux look in the default places, but man on FreeBSD does not do this.
>How-To-Repeat:
$ unset MANPATH; git help tag
No manual entry for git-tag

>Fix:
Patch git's build system so its idea of the man path agrees with where the man pages are installed by the port.

Patch attached with submission follows:

diff --git a/port/Makefile b/port/Makefile
index a4d3f5a..ae3270b 100644
--- a/port/Makefile
+++ b/port/Makefile
@@ -253,7 +253,8 @@ verify: checksum
 		${DISTDIR}/${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|share/man/man3|man/man3|' ${WRKSRC}/perl/Makefile.PL
+	@${REINPLACE_CMD} -e 's|share/man|man|' ${WRKSRC}/perl/Makefile.PL \
+		${WRKSRC}/Makefile ${WRKSRC}/Documentation/Makefile
 .ifndef (WITH_CVS)
 	@${REINPLACE_CMD} -e '/git-cvsexportcommit.perl/d; \
 		/git-cvsimport.perl/d; \


>Release-Note:
>Audit-Trail:
>Unformatted: