ports/133411: www/mod_encoding does not work on amd64 with apache22

[Tsurutani Naoki]

>Number:         133411
>Category:       ports
>Synopsis:       www/mod_encoding does not work on amd64 with apache22
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 06 05:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Tsurutani Naoki
>Release:        FreeBSD 7.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD h120.65.226.10.32118.vlan.kuins.net 7.1-STABLE FreeBSD 7.1-STABLE #17: Wed Jan 7 11:14:01 JST 2009 turutani at h120.65.226.10.32118.vlan.kuins.net:/usr/local/work/usr/obj/usr/src/sys/POLYMER i386


	
>Description:
	using www/mod_encoding with apache22 on FreeBSD/amd64 causes Segmentation
	Fault of the chils process.
	
>How-To-Repeat:
	only on amd64 with apache22. with apache20 and apache13, no troubles found.
	
>Fix:
	missing header inclusion. maybe the difference of sizeof(int) and sizeof(char*).
	here is a patch to www/mod_encoding.

--- files/apache22_patch.orig	2008-12-28 17:08:59.000000000 +0900
+++ files/apache22_patch	2009-04-06 13:35:30.000000000 +0900
@@ -78,7 +78,7 @@
  #include <http_log.h>
  #include <http_protocol.h>
  #include <http_request.h>
-+/* #include <ap_compat.h> */
++#include <apr_strings.h>
  
 +/* #include <iconv_hook/iconv.h> */
 +#include <regex.h>
@@ -241,8 +241,9 @@
    if (*args && (arg = ap_getword_conf_nc(cmd->pool, &args))) {
 -    LOG(APLOG_DEBUG, cmd->server, "add_client_encoding: agent: %s", arg);
 -    *(void **)ap_push_array(conf->client_encoding) =
+-      ap_pregcomp(cmd->pool, arg, REG_EXTENDED|REG_ICASE|REG_NOSUB);
 +    *(void **)apr_array_push(conf->client_encoding) =
-       ap_pregcomp(cmd->pool, arg, REG_EXTENDED|REG_ICASE|REG_NOSUB);
++      ap_pregcomp(cmd->pool, arg, AP_REG_EXTENDED|AP_REG_ICASE|AP_REG_NOSUB);
    }
  
    /* register list of possible encodings from above useragent */
	


>Release-Note:
>Audit-Trail:
>Unformatted: