ports/133384: port: mail/spamass-milter needs more sleep at start-up

[Jeffrey Goldberg]

>Number:         133384
>Category:       ports
>Synopsis:       port: mail/spamass-milter needs more sleep at start-up
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 04 20:30:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Jeffrey Goldberg
>Release:        FreeBSD 7.2-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD winky.ewd.goldmark.org 7.2-PRERELEASE FreeBSD 7.2-PRERELEASE #2: Fri Mar 27 16:20:36 CDT 2009 root at winky.ewd.goldmark.org:/usr/obj/usr/src/sys/WINKY i386


>Description:
	When starting up spamass-milter on my system, the socket file did not
	exist by the time that the start-up script tried to change the
	the ownership of the file.  Thus the group was not being set
	to "mail" for the socket file and postfix was unable to communicate
	with the milter.

	Note that this problem had NOT occurred on a slower system.  It is
	only after a server upgrade that this problem occurred.

	Also, as speculation, I doubt that this problem would occur for those
	using sendmail as their MTA (I use postfix), because there is a
	conditional "sleep 1" for HUPping sendmail that will never happen
	when sendmail isn't used.
>How-To-Repeat:
	On a sufficiently fast system, include a non-default socket group
	in /etc/rc.conf

             spamass_milter_socket_group="mail"

	And start this on a system that is running an MTA other than
	sendmail.

	You should see an error at startup with chown complaining that
	the socket file doesn't exist.  Later look at the socket file and
	you will see that it has its default group of "wheel" instead of
	"mail".
>Fix:

	Modify the start-up script to make the "sleep 1" unconditional

--- spamass-milter.orig	2009-04-04 14:47:35.000000000 -0500
+++ spamass-milter	2009-04-04 14:48:50.000000000 -0500
@@ -29,9 +29,9 @@
 
 start_postcmd()
 {
+  sleep 1
   if test -f /var/run/sendmail.pid
   then
-	sleep 1
 	kill -HUP `head -1 /var/run/sendmail.pid`
   fi
 

>Release-Note:
>Audit-Trail:
>Unformatted: