ports/128751: Bug fix for astro/gpsman-6.4

[David Wolfskill]

>Number:         128751
>Category:       ports
>Synopsis:       Bug fix for astro/gpsman-6.4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 10 13:20:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     David Wolfskill
>Release:        FreeBSD 6.4-PRERELEASE i386
>Organization:
Wolfskill & Dowling Residence
>Environment:
System: FreeBSD g1-60.catwhisker.org 6.4-PRERELEASE FreeBSD 6.4-PRERELEASE #653: Sat Nov  1 07:49:48 PDT 2008     root at g1-60.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY  i386


>Description:
	The author of GPSMan has created corrections for 2 post-release
	bugs found in GPSMan-6.4.  He has indicated that he plans to
	wait a week or two before rolling the 6.4.1 release.

	Since he only posted updated versions of the two files involved
	(vs. rolling a new release), I have made appropriate patches (and
	verified that applying them yields appropriate MD5 checksums) and
	bumped PORTREVISION.
>How-To-Repeat:
	The author's message didn't explicitly state how to repeat; he
	did point to <http://www.ncc.up.pt/gpsman/wGPSMan_15.html>,
	however.
>Fix:
	Apply the following patch, then use your prefrred tool to
	upgrade the port:

diff -ruN gpsman/Makefile gpsman/Makefile
--- gpsman/Makefile	2008-10-29 08:32:07.000000000 -0700
+++ gpsman/Makefile	2008-11-10 04:48:31.000000000 -0800
@@ -7,6 +7,7 @@
 
 PORTNAME=	gpsman
 PORTVERSION=	6.4
+PORTREVISION=	1
 CATEGORIES=	astro tk geography
 MASTER_SITES=	http://www.ncc.up.pt/gpsman/gpsmanhtml/
 MASTER_SITE_SUBDIR=	science/cartography
diff -ruN gpsman/files/patch-garmin.tcl gpsman/files/patch-garmin.tcl
--- gpsman/files/patch-garmin.tcl	1969-12-31 16:00:00.000000000 -0800
+++ gpsman/files/patch-garmin.tcl	2008-11-10 04:53:22.000000000 -0800
@@ -0,0 +1,30 @@
+diff -ruN gmsrc/garmin.tcl gmsrc/garmin.tcl
+--- gmsrc/garmin.tcl	2008-10-28 10:19:48.000000000 -0700
++++ gmsrc/garmin.tcl	2008-11-10 04:39:44.000000000 -0800
+@@ -17,7 +17,7 @@
+ #      along with this program.
+ #
+ #  File: garmin.tcl
+-#  Last change:  23 October 2008
++#  Last change:  2 November 2008
+ #
+ # Includes contributions by
+ # - David Gardner (djgardner_AT_users.sourceforge.net) marked
+@@ -2567,7 +2567,7 @@
+ }
+ 
+ proc ConvGarminDate {gd} {
+-    # converts Garmin date (seconds since 1990.01.01 00:00:00) into list
++    # converts Garmin date (seconds since 1989.12.31 00:00:00) into list
+     #  with date in current format and seconds since beginning of $YEAR0,
+     #  not necessarily a leap year, but < 1990
+     global YEAR0 TimeOffset
+@@ -2579,7 +2579,7 @@
+ 	if { $yy%100!=0 || $yy%400==0 } { incr dd }
+ 	incr yy 4
+     }
+-    set secs [expr round((((1990-$YEAR0)*365+$dd)*24+$TimeOffset-12)*3600+$gd)]
++    set secs [expr round((((1990-$YEAR0)*365+$dd)*24+$TimeOffset)*3600+$gd)]
+     return [list [DateFromSecs $secs] $secs]
+ }
+ 
diff -ruN gpsman/files/patch-wrtdials.tcl gpsman/files/patch-wrtdials.tcl
--- gpsman/files/patch-wrtdials.tcl	1969-12-31 16:00:00.000000000 -0800
+++ gpsman/files/patch-wrtdials.tcl	2008-11-10 04:53:32.000000000 -0800
@@ -0,0 +1,22 @@
+diff -ruN gmsrc/wrtdials.tcl gmsrc/wrtdials.tcl
+--- gmsrc/wrtdials.tcl	2008-10-28 10:19:48.000000000 -0700
++++ gmsrc/wrtdials.tcl	2008-11-10 04:39:44.000000000 -0800
+@@ -17,7 +17,7 @@
+ #      along with this program.
+ #
+ #  File: wrtdials.tcl
+-#  Last change:  14 September 2008
++#  Last change:  8 November 2008
+ #
+ # Includes contributions by
+ #  - Brian Baulch (baulchb _AT_ onthenet.com.au) marked "BSB contribution"
+@@ -4099,8 +4099,8 @@
+ 				}
+ 				break
+ 			    }
++			    incr i
+ 			}
+-			incr i
+ 		    }
+ 		}
+ 		if { $wh == "WP" } {
>Release-Note:
>Audit-Trail:
>Unformatted: