ports/124798: [patch] irc/bitlbee is not doing SRV lookups for XMPP protocol

[Ashish Shukla]

>Number:         124798
>Category:       ports
>Synopsis:       [patch] irc/bitlbee is not doing SRV lookups for XMPP protocol
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 20 21:20:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ashish Shukla
>Release:        FreeBSD 7.0-RELEASE-p1 amd64
>Organization:
N/A
>Environment:
System: FreeBSD chateau.d.lf 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #0: Sun Jun 8 15:23:17 IST 2008 toor at chateau.d.lf:/usr/obj/usr/src/sys/ULE amd64


>Description:
bitlbee capable of doing SRV lookups required to detect XMPP server
responsible for the domain name, is not doing it because of misconfiguration .
>How-To-Repeat:
1. Connect to bitlbee instance with an irc client.

2. Authenticate to it.

3. Add an XMPP account with following command in '&bitlbee' window of IRC client.

   account add username at domain.tld password

4. If domain.tld is not listening on port 5222, bitlbee should do SRV DNS record
   lookup for _xmpp-client._tcp.domain.tld. to determine the XMPP server responsible for
   domain.tld.

5. Instead of performing SRV lookup, it keeps try to connect to domain.tld:5222 . So,
   one has to either explicitly specify a server or depend on SRV lookup.

>Fix:
diff -urN /usr/ports/irc/bitlbee/Makefile bitlbee/Makefile
--- /usr/ports/irc/bitlbee/Makefile	2008-06-06 19:06:38.000000000 +0530
+++ bitlbee/Makefile	2008-06-20 21:25:16.000000000 +0530
@@ -7,7 +7,7 @@
 
 PORTNAME=	bitlbee
 PORTVERSION=	1.2
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	irc
 MASTER_SITES=	http://get.bitlbee.org/src/ \
 		${MASTER_SITE_LOCAL}
diff -urN /usr/ports/irc/bitlbee/files/patch-configure bitlbee/files/patch-configure
--- /usr/ports/irc/bitlbee/files/patch-configure	1970-01-01 05:30:00.000000000 +0530
+++ bitlbee/files/patch-configure	2008-06-20 21:22:54.000000000 +0530
@@ -0,0 +1,31 @@
+
+$FreeBSD$
+
+--- configure.orig
++++ configure
+@@ -322,13 +322,19 @@
+ 
+ echo 'SSL_CLIENT=ssl_'$ssl'.o' >> Makefile.settings
+ 
+-for i in /lib /usr/lib /usr/local/lib; do
+-	if [ -f $i/libresolv.a ]; then
++if [ $arch = FreeBSD ]; then
++	if [ `strings /lib/libc.so.7 |grep res_query |wc -l` -gt 0 ]; then
+ 		echo '#define HAVE_RESOLV_A' >> config.h
+-		echo 'EFLAGS+='$i'/libresolv.a' >> Makefile.settings
+-		break
+-	fi
+-done
++	fi;
++else
++	for i in /lib /usr/lib /usr/local/lib; do
++		if [ -f $i/libresolv.a ]; then
++			echo '#define HAVE_RESOLV_A' >> config.h
++			echo 'EFLAGS+='$i'/libresolv.a' >> Makefile.settings
++			break
++		fi
++	done
++fi;
+ 
+ STORAGES="text xml"
+ 

>Release-Note:
>Audit-Trail:
>Unformatted: