ports/116721: Upgrade of print/cups-base fails

[Christoph Moench-Tegeder]

>Number:         116721
>Category:       ports
>Synopsis:       Upgrade of print/cups-base fails
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 28 19:30:02 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 6.2-RELEASE-p7 i386
>Organization:
>Environment:
System: FreeBSD elch.haidundneu23.net 6.2-RELEASE-p7 FreeBSD 6.2-RELEASE-p7 #4: Sat Sep 1 13:33:13 CEST 2007 cmt at elch.haidundneu23.net:/usr/obj/usr/src/sys/CMT i386
cups-base-1.2.12, upgrading to cups-base-1.3.0
>Description:
	When upgrading cups-base from 1.2.12 to 1.3.0 (e.g. portupgrade),
	compilation fails in cups-1.3.0/cgi-bin because of undefined symbols
	(first one is CUPS_SERVER_REMOTE_ANY in cups-1.3.0/cgi-bin/admin.c).
>How-To-Repeat:
	portupgrade print/cups-base or even a simple make in
	ports/print/cups-base. Note: to trigger this bug, an older version of
	cups-base has to be installed.
>Fix:
	There is an error in the ordering of compiler arguments, tho old headers
	in /usr/local/include get precedence over the current ones in cups'
	source directory. When assembling ALL_CFLAGS in Makedefs, $(CFLAGS)
	has to go before $(SSLFLAGS). Put the following patch in
	files/patch-Makedefs.in. In case some mail system garbles this patch,
	get it at http://www.burggraben.net/hacks/patch-Makedefs.in

--- Makedefs.in.orig	Fri Sep 28 21:13:27 2007
+++ Makedefs.in	Fri Sep 28 21:13:48 2007
@@ -108,8 +108,8 @@
 #               for extra debug info)
 #
 
-ALL_CFLAGS	=	$(SSLFLAGS) @LARGEFILE@ @PTHREAD_FLAGS@ \
-			$(OPTIONS) $(CFLAGS)
+ALL_CFLAGS	=	$(CFLAGS) $(SSLFLAGS) @LARGEFILE@ @PTHREAD_FLAGS@ \
+			$(OPTIONS)
 ARCHFLAGS	=	@ARCHFLAGS@
 ARFLAGS		=	@ARFLAGS@
 BACKLIBS	=	@BACKLIBS@

>Release-Note:
>Audit-Trail:
>Unformatted: