ports/117629: [PATCH] multimedia/libquicktime: GtkTooltips have been deprecated

[Randy Pratt]

>Number:         117629
>Category:       ports
>Synopsis:       [PATCH] multimedia/libquicktime: GtkTooltips have been deprecated
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 29 14:20:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Randy Pratt
>Release:        6.2-STABLE
>Organization:
>Environment:
6.2-STABLE FreeBSD 6.2-STABLE #0: Thu Sep 20 12:16:05 EDT 2007
>Description:
gmake[2]: Entering directory `/usr/ports/multimedia/libquicktime/work/libquicktime-1.0.0/utils'
Making all in gtk
gmake[3]: Entering directory `/usr/ports/multimedia/libquicktime/work/libquicktime-1.0.0/utils/gtk'
if cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../include  -I/usr/local/include -I/usr/local/include  -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2   -DGTK_DISABLE_DEPRECATED -DLOCALE_DIR=\"/usr/local/share/locale\" -O3 -funroll-all-loops -fomit-frame-pointer  -finline-functions -Wall -Winline -MT lqt_gtk.o -MD -MP -MF ".deps/lqt_gtk.Tpo" -c -o lqt_gtk.o lqt_gtk.c; \
	then mv -f ".deps/lqt_gtk.Tpo" ".deps/lqt_gtk.Po"; else rm -f ".deps/lqt_gtk.Tpo"; exit 1; fi
In file included from lqt_gtk.c:2:
lqt_gtk.h:24: error: syntax error before "GtkTooltips"
lqt_gtk.h:28: error: syntax error before "GtkTooltips"
lqt_gtk.h:50: error: syntax error before "GtkTooltips"
lqt_gtk.c: In function `set_combo_tooltip':
lqt_gtk.c:167: warning: implicit declaration of function `gtk_tooltips_set_tip'
lqt_gtk.c:167: error: structure has no member named `tooltips'
lqt_gtk.c: At top level:
lqt_gtk.c:184: error: syntax error before "GtkTooltips"
lqt_gtk.c: In function `lqtgtk_create_parameter_widget':
lqt_gtk.c:188: error: structure has no member named `tooltips'
lqt_gtk.c:188: error: `tooltips' undeclared (first use in this function)
lqt_gtk.c:188: error: (Each undeclared identifier is reported only once
lqt_gtk.c:188: error: for each function it appears in.)
lqt_gtk.c:189: error: `info' undeclared (first use in this function)
lqt_gtk.c:200: error: structure has no member named `tooltips'
lqt_gtk.c:219: error: structure has no member named `tooltips'
lqt_gtk.c:236: error: structure has no member named `tooltips'
lqt_gtk.c:263: error: structure has no member named `tooltips'
lqt_gtk.c:284: error: structure has no member named `tooltips'
lqt_gtk.c:292: error: structure has no member named `tooltips'
lqt_gtk.c: At top level:
lqt_gtk.c:346: error: syntax error before "GtkTooltips"
lqt_gtk.c: In function `create_table':
lqt_gtk.c:350: error: `num_parameters' undeclared (first use in this function)
lqt_gtk.c:360: error: `widgets' undeclared (first use in this function)
lqt_gtk.c:361: error: `parameter_info' undeclared (first use in this function)
lqt_gtk.c:361: error: `tooltips' undeclared (first use in this function)
lqt_gtk.c: In function `lqtgtk_create_codec_config_widget':
lqt_gtk.c:394: error: structure has no member named `tooltips'
lqt_gtk.c:394: warning: implicit declaration of function `gtk_tooltips_new'
lqt_gtk.c:395: error: structure has no member named `tooltips'
lqt_gtk.c:400: error: structure has no member named `tooltips'
lqt_gtk.c:438: error: structure has no member named `tooltips'
lqt_gtk.c:456: error: structure has no member named `tooltips'
gmake[3]: *** [lqt_gtk.o] Error 1
gmake[3]: Leaving directory `/usr/ports/multimedia/libquicktime/work/libquicktime-1.0.0/utils/gtk'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/multimedia/libquicktime/work/libquicktime-1.0.0/utils'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/multimedia/libquicktime/work/libquicktime-1.0.0'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/multimedia/libquicktime.
*** Error code 1

Stop in /usr/ports/multimedia/libquicktime.
>How-To-Repeat:
Build or update to libquicktime-1.0.0_5
>Fix:
GtkTooltips have been deprecated in favor of a new tooltips
implementation.  See discussion:

  http://www.gossamer-threads.com/lists/atrpms/devel/9626

which references a patch that seems to work:

  http://kuoi.asui.uidaho.edu/~wes/libquicktime-oldstyle-tooltips.diff


Patch attached with submission follows:

--- configure.ac.orig	2007-09-28 23:02:19.000000000 -0700
+++ configure.ac	2007-09-28 23:03:06.000000000 -0700
@@ -364,9 +364,6 @@
 AM_CONDITIONAL(HAVE_GTK, test x$have_gtk = xtrue)
 AC_SUBST(GTK_REQUIRED)
 
-dnl Always be in sync with the newest gtk
-GTK_CFLAGS="$GTK_CFLAGS -DGTK_DISABLE_DEPRECATED"
-
 dnl
 dnl Check for libdv
 dnl
--- configure.orig	2007-09-28 23:23:58.000000000 -0700
+++ configure	2007-09-28 23:24:37.000000000 -0700
@@ -28893,8 +28893,6 @@
 
 
 
-GTK_CFLAGS="$GTK_CFLAGS -DGTK_DISABLE_DEPRECATED"
-
 
 have_libdv="false"
 


>Release-Note:
>Audit-Trail:
>Unformatted: