ports/117230: Make multimedia/xmms respect WITHOUT_GETTEXT/WITHOUT_NLS option

[Oleg Pudeyev]

>Number:         117230
>Category:       ports
>Synopsis:       Make multimedia/xmms respect WITHOUT_GETTEXT/WITHOUT_NLS option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 16 05:20:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Oleg Pudeyev
>Release:        6.2-RELEASE
>Organization:
>Environment:
FreeBSD kappa.universe 6.2-RELEASE FreeBSD 6.2-RELEASE #2: Wed Jul 18 01:25:26 EDT 2007     root at kappa.universe:/build/src/sys/i386/compile/KAPPA  i386
>Description:
Attached patch makes multimedia/xmms port respect WITHOUT_GETTEXT and WITHOUT_NLS options (which have the same effect). I copied the code dealing with them from databases/postgresql82-server port.

After applying this patch and enabling WITHOUT_NLS, I can successfully build audio/xmmsctrl. From what I can gather multimedia/xmms port links xmms, but not libxmms.so, with libintl.so, when libxmms.so uses gettext. Thus, any other ports that attempt to link with libxmms.so but not with libintl.so get unresolved symbol errors. My autotools-fu is not strong enough to fix this properly in xmms source; instead, removing gettext support from xmms altogether is, for me, a viable alternative.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/multimedia/xmms/Makefile,v
retrieving revision 1.90
diff -u -r1.90 Makefile
--- Makefile	3 Oct 2007 23:42:22 -0000	1.90
+++ Makefile	16 Oct 2007 05:01:50 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	xmms
 PORTVERSION=	1.2.10
-PORTREVISION=	10
+PORTREVISION=	11
 CATEGORIES+=	multimedia audio ipv6
 MASTER_SITES=	http://www.xmms.org/files/1.2.x/
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX}
@@ -20,7 +20,13 @@
 USE_GNOME=	gtk12 gnomehack
 WANT_GNOME=	yes
 USE_GMAKE=	yes
+
+.if !(defined(WITHOUT_GETTEXT) || defined(WITHOUT_NLS))
 USE_GETTEXT=	yes
+.else
+CONFIGURE_ARGS+=	--disable-nls
+.endif
+
 USE_ICONV=	yes
 USE_LDCONFIG=	yes
 GNU_CONFIGURE=	yes


>Release-Note:
>Audit-Trail:
>Unformatted: