ports/117031: multimedia/fxtv: fails in the start in i810e set to 16bits color.

[Tatsuki Makino]

>Number:         117031
>Category:       ports
>Synopsis:       multimedia/fxtv: fails in the start in i810e set to 16bits color.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 08 19:50:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Tatsuki Makino
>Release:        FreeBSD 6.2-RELEASE-p8 i386
>Organization:
>Environment:
FreeBSD FreeBSD.test 6.2-RELEASE-p8 FreeBSD 6.2-RELEASE-p8 #0: Sun Oct  7 21:02:21 JST 2007     root at FreeBSD.test:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When X start 16 bits color mode, fxtv chooses 32 bits color why.
It causes the BadMatch error.
>How-To-Repeat:
startx -- :0 -depth 16
fxtv &

WARNING:  Non-default X visuals not supported yet.

X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  55 (X_CreateGC)
  Serial number of failed request:  59
  Current serial number in output stream:  61

>Fix:
1. Use 24bit color mode. (But, it also has other trouble...)
2. This file is put on multimedia/fxtv/files/patch-xutil.c . (Other users should check this.)

Patch attached with submission follows:

--- ./xutil.c.orig	Fri Nov  5 09:38:54 1999
+++ ./xutil.c	Tue Oct  9 03:41:54 2007
@@ -1500,8 +1500,10 @@
     /**********************************************************************/
 
     vinfo_pref.screen = screen;
-    visual = XGetVisualInfo( display, VisualScreenMask, &vinfo_pref, 
-                             &num_visuals );
+    vinfo_pref.depth = DefaultDepth( display, screen );
+    visual = XGetVisualInfo( display,
+                             VisualScreenMask | VisualDepthMask,
+                             &vinfo_pref, &num_visuals );
     if ( num_visuals == 0 ) {
         fprintf( stderr, "XGetVisualInfo() says no visuals available!\n" );
         exit(1);


>Release-Note:
>Audit-Trail:
>Unformatted: