ports/117832: ports-mgmt/portlint: [PATCH]: allow [ to start COMMENT
Philip M. Gollucci
pgollucci at p6m7g8.com
Mon Nov 5 05:10:01 UTC 2007
>Number: 117832
>Category: ports
>Synopsis: ports-mgmt/portlint: [PATCH]: allow [ to start COMMENT
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 05 05:10:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Philip M. Gollucci
>Release: FreeBSD 8.0-CURRENT
>Organization:
Riderway Inc.
>Environment:
FreeBSD home.p6m7g8.net 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Nov 4 01:36:52 EDT 2007 pgollucci at home.p6m7g8.net:/usr/obj/usr/src/sys/HOME i386
>Description:
Filed b/c of rejected
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/117120
to allow things like [X]Emacs
Something like (V)im would be similar I guess, but I didn't include them here.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: portlint.pl
===================================================================
RCS file: /home/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.95
diff -u -r1.95 portlint.pl
--- portlint.pl 17 Aug 2007 17:11:40 -0000 1.95
+++ portlint.pl 5 Nov 2007 03:56:44 -0000
@@ -2279,7 +2279,7 @@
&perror("WARN", $file, -1, "unless this is a master port, COMMENT has to be set by \"=\", ".
"not by \"$1=\".") unless ($masterport);
} else { # check for correctness
- if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
+ if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
&perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period");
} elsif (length($makevar{COMMENT}) > 70) {
&perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit.");
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list