ports/112898: x11-wm/windowmaker build broken with NDEBUG option

[Hyogeol Lee]

>Number:         112898
>Category:       ports
>Synopsis:       x11-wm/windowmaker build broken with NDEBUG option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 23 18:00:09 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Hyogeol Lee
>Release:        -current 7.0
>Organization:
>Environment:
FreeBSD localhost.localdomain 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sun May 20 01:18:43 KST 2007     root at localhost.localdomain:/usr/obj/usr/src/sys/EZ8KERNEL  amd64

>Description:
Not serious problem, just linking error with NDEBUG option.

Error message is below.

cc -DNDEBUG -O2 -pipe -fno-strict-aliasing -march=athlon64 -o connect connect.o  -L/usr/local/lib ../../WINGs/libWUtil.a /usr/local/lib/libintl.so /usr/local/lib/libiconv.so -Wl,--rpath -Wl,/usr/local/lib -Wl,--rpath -Wl,/usr/local/lib
./../WINGs/libWUtil.a(string.o)(.text+0x10): In function `wstrdup':
: undefined reference to `assert'
./../WINGs/libWUtil.a(string.o)(.text+0x179): In function `wstrndup':
: undefined reference to `assert'

>How-To-Repeat:
Build x11-wm/windowmaker with NDEBUG option.
>Fix:
I attached patch file.


Patch attached with submission follows:

--- WINGs/WINGs/WUtil.h.orig	Thu May 24 02:16:36 2007
+++ WINGs/WINGs/WUtil.h	Thu May 24 02:16:55 2007
@@ -34,6 +34,10 @@
 #define wassertr(expr)		{}
 #define wassertrv(expr, val)	{}
 
+#ifndef assert
+#define assert(e) {}
+#endif
+
 #else /* !NDEBUG */
 
 #ifdef DEBUG

>Release-Note:
>Audit-Trail:
>Unformatted: