ports/112884: security/tripwire: fails to build on FreeBSD 7.0-CURRENT after import of GCC 4.2

[Scot Hetzel]

>Number:         112884
>Category:       ports
>Synopsis:       security/tripwire: fails to build on FreeBSD 7.0-CURRENT after import of GCC 4.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 23 06:50:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Scot Hetzel
>Release:        7.0-CURRENT
>Organization:
Ye Old Computer
>Environment:
FreeBSD hp010.hetzel.org 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sat May 19 01:51:34 CDT 2007     root at hp010.hetzel.org:/usr/src/7x/sys-p4/amd64/compile/GENERIC.debug  amd64

>Description:
Tripwire fails to build on 7.0-CURRENT after import of GCC 4.2.

gmake[1]: Entering directory `/usr/ports/security/tripwire/work/tripwire-2.4.0.1/src/fco'
c++ -DHAVE_CONFIG_H              -I. -I. -I../.. -I..  -I/usr/local/include   -O2 -fno-strict-aliasing -pipe -c -o fco.o fco.cpp
c++ -DHAVE_CONFIG_H              -I. -I. -I../.. -I..  -I/usr/local/include   -O2 -fno-strict-aliasing -pipe -c -o fcocompare.o fcocompare.cpp
c++ -DHAVE_CONFIG_H              -I. -I. -I../.. -I..  -I/usr/local/include   -O2 -fno-strict-aliasing -pipe -c -o fcodatasourceiter.o fcodatasourceiter.cpp
In file included from fcodatasourceiter.h:50,
                 from fcodatasourceiter.cpp:41:
fconame.h:147: error: ISO C++ forbids declaration of 'cFCOName_i' with no type
fconame.h:147: error: expected ';' before '*' token
gmake[1]: *** [fcodatasourceiter.o] Error 1
gmake[1]: Leaving directory `/usr/ports/security/tripwire/work/tripwire-2.4.0.1/src/fco'
gmake: *** [all-recursive] Error 1
*** Error code 2

Stop in /usr/ports/security/tripwire.

This type of error occurs in 3 files:

src/fco/fconame.h
src/fco/fcosetimpl.h
src/tw/fcoreport.h

I found the solution thru a google search.
>How-To-Repeat:
On a recent 7-CURRENT system:
cd /usr/ports/security/tripwire
make build
>Fix:
Apply the attached patch.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/security/tripwire/Makefile,v
retrieving revision 1.36
diff -u -r1.36 Makefile
--- Makefile	20 Jun 2006 01:47:23 -0000	1.36
+++ Makefile	23 May 2007 06:33:43 -0000
@@ -57,6 +57,10 @@
 RUN_DEPENDS=	${LOCALBASE}/lib/libstlport_gcc.so:${PORTSDIR}/devel/stlport
 .endif
 
+.if ${OSVERSION} >= 700042
+EXTRA_PATCHES+=	${FILESDIR}/tripwire-gcc4-patch
+.endif
+
 PLIST_SUB+=	TWCFG=${TWCFG} TWDB=${TWDB}
 
 pre-configure:
Index: files/tripwire-gcc4-patch
===================================================================
RCS file: files/tripwire-gcc4-patch
diff -N files/tripwire-gcc4-patch
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/tripwire-gcc4-patch	23 May 2007 06:21:33 -0000
@@ -0,0 +1,31 @@
+--- src/fco/fconame.h-orig	Thu Sep 15 22:12:38 2005
++++ src/fco/fconame.h	Tue May 22 19:15:46 2007
+@@ -49,6 +49,7 @@
+ ///////////////////////////////////////////////////////////////////////////////
+ class cFCONameTblNode;
+ class cFCONameIter;
++class cFCOName_i;
+ 
+ class cFCOName : public iTypedSerializable
+ {
+--- src/fco/fcosetimpl.h-orig	Thu Sep 15 22:12:38 2005
++++ src/fco/fcosetimpl.h	Tue May 22 19:16:54 2007
+@@ -46,6 +46,8 @@
+ #include "fconame.h"
+ #endif
+ 
++class cFCOIterImpl;
++
+ class cFCOSetImpl : public iFCOSet
+ {
+ 	friend class cFCOIterImpl;
+--- src/tw/fcoreport.h-orig	Thu Sep 15 22:12:37 2005
++++ src/tw/fcoreport.h	Tue May 22 19:18:17 2007
+@@ -74,6 +74,7 @@
+ class cFCOName;
+ class cFCOReport_i;
+ class cFCOReportGenreIter_i;
++class cFCOReportSpecIter;
+ class cFCOReportSpecIter_i;
+ class cFCOReportChangeIter_i;
+ class iFCOSpec;

>Release-Note:
>Audit-Trail:
>Unformatted: