ports/112806: x11/xorg doesn't build on a system with NO_RCMDS=yes

[Olivier]

>Number:         112806
>Category:       ports
>Synopsis:       x11/xorg doesn't build on a system with NO_RCMDS=yes
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 20 14:10:04 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Olivier
>Release:        FreeBSD 6.2-STABLE #0: Fri Apr 27 16:19:36 CEST 2007
>Organization:
gid0.org
>Environment:
FreeBSD 6.2-STABLE #0: Fri Apr 27 16:19:36 CEST 2007
>Description:
When using a fresh system installed with NO_RCMDS=yes in /etc/make.conf (or /etc/src.conf for -CURRENT), x11/xorg fails to compile because of x11/xorg-apps which depends on x11/xsm which wants an rsh-like program during configure :

# cd /usr/ports/x11/xorg
# make install clean
[...]
checking for a BSD-compatible install... /usr/bin/install -c -o root -g wheel
checking for rsh... no
checking for rcmd... no
checking for remsh... no
configure: error: No rsh like program found
===>  Script "configure" failed unexpectedly.
[...]
*** Error code 1

Stop in /usr/ports/x11/xsm.
*** Error code 1

Stop in /usr/ports/x11/xorg-apps.
*** Error code 1

Stop in /usr/ports/x11/xorg.
>How-To-Repeat:
# echo 'NO_RCMDS=yes' >> /etc/make.conf
# cd /usr/src
# make buildworld
# make installworld
# make delete-old
# cd /usr/ports/x11/xsm
# make

>Fix:
Since x11/xsm can't be built without RSH, remove the line
xsm:${PORTSDIR}/x11/xsm \
from x11/xorg-apps/Makefile

Or, if you need xsm, (only a temporary workaround, very dirty) :
# touch /usr/local/bin/rsh
# cd /usr/ports/x11/xsm
# make install clean
# rm /usr/local/bin/rsh
# cd /usr/ports/x11/xorg
# make install clean

It would maybe be better for x11/xorg-apps to only install xsm if {rsh,rcmd,remsh} is present, or if NO_RCMDS isn't set.

>Release-Note:
>Audit-Trail:
>Unformatted: